Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 11364194: Introduce Tile Versions (Closed)

Created:
8 years, 1 month ago by nduca
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -28 lines) Patch
M cc/tile.h View 1 3 chunks +51 lines, -4 lines 0 comments Download
M cc/tile.cc View 1 2 1 chunk +45 lines, -2 lines 0 comments Download
M cc/tile_manager.h View 2 chunks +16 lines, -5 lines 0 comments Download
M cc/tile_manager.cc View 1 chunk +40 lines, -10 lines 0 comments Download
M cc/tile_priority.h View 3 chunks +45 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nduca
More baby steps.
8 years, 1 month ago (2012-11-10 03:00:30 UTC) #1
enne (OOO)
lgtm, with one ownership nit: http://codereview.chromium.org/11364194/diff/1/cc/tile.h File cc/tile.h (right): http://codereview.chromium.org/11364194/diff/1/cc/tile.h#newcode30 cc/tile.h:30: scoped_ptr<PicturePile> picture_pile) This is ...
8 years, 1 month ago (2012-11-10 03:04:45 UTC) #2
nduca
Good point, i'll make that switch.
8 years, 1 month ago (2012-11-10 03:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11364194/9002
8 years, 1 month ago (2012-11-10 03:45:35 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-10 04:42:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11364194/2002
8 years, 1 month ago (2012-11-10 07:37:01 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-10 09:38:08 UTC) #7
Change committed as 167079

Powered by Google App Engine
This is Rietveld 408576698