Fix VAOs and client side arrays

Fix VAOs and client side arrays

Vertex Array Objects were broke for client side arrays

BUG=160482
[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170281

[greggman, 2012-11-26 10:21:39]

Hey Brandon, Al, PTAL

This now passes the GLES2 conformance tests for VAOs.

Once checked in I'll enable the test (right now it's commented out because of
the failures)

[bajones, 2012-11-26 18:01:06]

I've been meaning to look into this since you mentioned it, but I see now that
it was a much larger change that I had anticipated. Thanks for tackling this.

LGTM, though I am not a committer so you'll need a second opinion. Only a couple
of questions:

https://codereview.chromium.org/11413094/diff/39/gpu/command_buffer/client/gl...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/11413094/diff/39/gpu/command_buffer/client/gl...
gpu/command_buffer/client/gles2_implementation.cc:896: for (int32 i = 0; i < 1;
++i) {
Is this a debugging change that should have been reverted? Otherwise it seems
like the for loop should be eliminated

https://codereview.chromium.org/11413094/diff/39/gpu/command_buffer/common/id...
File gpu/command_buffer/common/id_allocator.h (right):

https://codereview.chromium.org/11413094/diff/39/gpu/command_buffer/common/id...
gpu/command_buffer/common/id_allocator.h:16: #include "../client/hash_tables.h"
It's not clear to me what this was required for.

[apatrick_chromium, 2012-11-26 20:08:21]

Arg! Big patch. It looks okay but the *_gpu failing tests look relevant.

[greggman, 2012-11-28 08:18:56]

the gpu bots seems to be fine now. The win try bot always fails that
WebGLGreenTriangle test, even with an empty CL :-(  Where as the win buildbot
doesn't :-(

https://codereview.chromium.org/11413094/diff/39/gpu/command_buffer/client/gl...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/11413094/diff/39/gpu/command_buffer/client/gl...
gpu/command_buffer/client/gles2_implementation.cc:896: for (int32 i = 0; i < 1;
++i) {
On 2012/11/26 18:01:06, bajones wrote:
> Is this a debugging change that should have been reverted? Otherwise it seems
> like the for loop should be eliminated

Done.

https://codereview.chromium.org/11413094/diff/39/gpu/command_buffer/common/id...
File gpu/command_buffer/common/id_allocator.h (right):

https://codereview.chromium.org/11413094/diff/39/gpu/command_buffer/common/id...
gpu/command_buffer/common/id_allocator.h:16: #include "../client/hash_tables.h"
On 2012/11/26 18:01:06, bajones wrote:
> It's not clear to me what this was required for.

Done.

[apatrick_chromium, 2012-11-28 20:32:29]

lgtm

[commit-bot: I haz the power, 2012-11-29 01:16:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11413094/4010

[commit-bot: I haz the power, 2012-11-29 01:16:20]

Presubmit check for 11413094-4010 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ppapi/native_client

Presubmit checks took 2.4s to calculate.

[commit-bot: I haz the power, 2012-11-29 02:08:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11413094/4010

[commit-bot: I haz the power, 2012-11-29 23:24:15]

Change committed as 170281