Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11413102: Remove TabContents from BrowserWindow and website settings. (Closed)

Created:
8 years, 1 month ago by Avi (use Gerrit)
Modified:
8 years, 1 month ago
CC:
chromium-reviews, vsevik, tfarina, sail+watch_chromium.org, yurys, pfeldman
Visibility:
Public.

Description

Remove TabContents from BrowserWindow and website settings. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169085

Patch Set 1 #

Patch Set 2 : missed one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -81 lines) Patch
M chrome/browser/debugger/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings_bubble_controller.h View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings_bubble_controller.mm View 6 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings_bubble_controller_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
markus: website settings rsesek/erg/sky: platformy stuff
8 years, 1 month ago (2012-11-20 22:00:03 UTC) #1
sky
LGTM
8 years, 1 month ago (2012-11-20 22:13:51 UTC) #2
Elliot Glaysher
gtk lgtm
8 years, 1 month ago (2012-11-20 22:29:48 UTC) #3
markusheintz_
On 2012/11/20 22:29:48, Elliot Glaysher wrote: > gtk lgtm website settings LGTM
8 years, 1 month ago (2012-11-21 08:01:24 UTC) #4
Robert Sesek
cocoa lgtm
8 years, 1 month ago (2012-11-21 16:22:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11413102/20
8 years, 1 month ago (2012-11-21 16:31:18 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-21 19:20:52 UTC) #7 
Change committed as 169085

Powered by Google App Engine
This is Rietveld 408576698