Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 11419023: Add ppapi_test for ppb_talk_private (Closed)

Created:
8 years, 1 month ago by Josh Horwich
Modified:
8 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Add ppapi_test for ppb_talk_private Adding a test for ppb_talk_private's GetPermission API. This should be helpful for http://codereview.chromium.org/11359147/ BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168146

Patch Set 1 #

Patch Set 2 : Adding to browser_tests as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -9 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + ppapi/tests/test_talk_private.h View 1 chunk +8 lines, -9 lines 0 comments Download
A ppapi/tests/test_talk_private.cc View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Josh Horwich
Please take a look - PPAPI test for PPB_Talk_Private. (Currently I disable it under Ash ...
8 years, 1 month ago (2012-11-15 23:11:27 UTC) #1
brettw
lgtm
8 years, 1 month ago (2012-11-15 23:29:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11419023/4003
8 years, 1 month ago (2012-11-16 00:49:01 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-16 07:31:27 UTC) #4
Change committed as 168146

Powered by Google App Engine
This is Rietveld 408576698