On Chrome uninstall, if App Launcher is installed, then hide the "Also delete your browser data?" c…

On Chrome uninstall, if App Launcher is installed, then hide the "Also delete your browser data?" check box.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171173

[huangs, 2012-11-29 01:30:17]

Verified that uninstall_view.cc file is complied for Windows only (includes
shell_util.cc).  Also, browser_ui already depends on launcher_support (in
Windows).  PTAL.

[tfarina, 2012-11-29 19:46:48]

The 'Reviewers' list is empyy.

You should fill it first with the person you want to review this, mostly Scott
(sky) in this case.

Click in 'Edit Issue' and fill the 'Reviewers' text box with sky so it'll
autocomplete with his address for you.

And then you 'Publish+Mail Comments', so the reviewers receives an email
alerting him to review this CL, otherwise he won't know.

Thank you.

[tfarina, 2012-11-29 19:52:35]

https://codereview.chromium.org/11421141/diff/4001/chrome/browser/ui/views/un...
File chrome/browser/ui/views/uninstall_view.cc (right):

https://codereview.chromium.org/11421141/diff/4001/chrome/browser/ui/views/un...
chrome/browser/ui/views/uninstall_view.cc:179:
!chrome_launcher_support::IsAppLauncherPresent());
just curious, why you need to pass this as a parameter to UninstallView?

You can still have the data member there, but in the initializer list you could
call this instead.

Scott might have other preferences though.

[huangs, 2012-11-29 21:32:31]

https://codereview.chromium.org/11421141/diff/4001/chrome/browser/ui/views/un...
File chrome/browser/ui/views/uninstall_view.cc (right):

https://codereview.chromium.org/11421141/diff/4001/chrome/browser/ui/views/un...
chrome/browser/ui/views/uninstall_view.cc:179:
!chrome_launcher_support::IsAppLauncherPresent());
I thought it'd be clearer to leave the decision to the caller, in case we want
to reuse the dialogue box for a different product.  However, this is not the
case (by design, App Launcher install will not ask).  So it's arbitrary, really.

[erikwright (departed), 2012-11-29 23:24:35]

https://codereview.chromium.org/11421141/diff/4001/chrome/browser/ui/views/un...
File chrome/browser/ui/views/uninstall_view.cc (right):

https://codereview.chromium.org/11421141/diff/4001/chrome/browser/ui/views/un...
chrome/browser/ui/views/uninstall_view.cc:179:
!chrome_launcher_support::IsAppLauncherPresent());
Actually, I would prefer for this flag to be passed by the caller of
ShowUninstallBrowserPrompt rather than introducing the dependency here.

[huangs, 2012-11-30 07:16:59]

PTAL.

https://codereview.chromium.org/11421141/diff/4001/chrome/browser/ui/views/un...
File chrome/browser/ui/views/uninstall_view.cc (right):

https://codereview.chromium.org/11421141/diff/4001/chrome/browser/ui/views/un...
chrome/browser/ui/views/uninstall_view.cc:179:
!chrome_launcher_support::IsAppLauncherPresent());
On 2012/11/29 23:24:35, erikwright wrote:
> Actually, I would prefer for this flag to be passed by the caller of
> ShowUninstallBrowserPrompt rather than introducing the dependency here.

Done, although this now makes browser depend on launcher_support (in Win).

[erikwright (departed), 2012-11-30 16:39:01]

LGTM.

https://codereview.chromium.org/11421141/diff/11001/chrome/browser/chrome_bro...
File chrome/browser/chrome_browser_main_win.cc (right):

https://codereview.chromium.org/11421141/diff/11001/chrome/browser/chrome_bro...
chrome/browser/chrome_browser_main_win.cc:126:
!chrome_launcher_support::IsAppLauncherPresent());
// Don't offer to delete the profile if the launcher is also installed.

[huangs, 2012-12-02 06:41:13]

+@ben for OWNER review for .gypi AND browser\ui\view.

https://codereview.chromium.org/11421141/diff/11001/chrome/browser/chrome_bro...
File chrome/browser/chrome_browser_main_win.cc (right):

https://codereview.chromium.org/11421141/diff/11001/chrome/browser/chrome_bro...
chrome/browser/chrome_browser_main_win.cc:126:
!chrome_launcher_support::IsAppLauncherPresent());
On 2012/11/30 16:39:01, erikwright wrote:
> // Don't offer to delete the profile if the launcher is also installed.

Done.

[Ben Goodger (Google), 2012-12-04 16:19:04]

lgtm

https://codereview.chromium.org/11421141/diff/3002/chrome/browser/ui/views/un...
File chrome/browser/ui/views/uninstall_view.h (right):

https://codereview.chromium.org/11421141/diff/3002/chrome/browser/ui/views/un...
chrome/browser/ui/views/uninstall_view.h:33: bool show_delete_profile_);
no trailing underscore

[tfarina, 2012-12-04 18:09:17]

https://codereview.chromium.org/11421141/diff/3002/chrome/browser/ui/views/un...
File chrome/browser/ui/views/uninstall_view.cc (right):

https://codereview.chromium.org/11421141/diff/3002/chrome/browser/ui/views/un...
chrome/browser/ui/views/uninstall_view.cc:177: run_loop.QuitClosure(),
I bet you can align this way:
... = new UninstallView(&result,
                        run_loop.QuitClosure(),
                        show_delete_profile);
                        ^ align here!

[huangs, 2012-12-05 03:18:18]

https://codereview.chromium.org/11421141/diff/3002/chrome/browser/ui/views/un...
File chrome/browser/ui/views/uninstall_view.cc (right):

https://codereview.chromium.org/11421141/diff/3002/chrome/browser/ui/views/un...
chrome/browser/ui/views/uninstall_view.cc:177: run_loop.QuitClosure(),
On 2012/12/04 18:09:18, tfarina wrote:
> I bet you can align this way:
> ... = new UninstallView(&result,
>                         run_loop.QuitClosure(),
>                         show_delete_profile);
>                         ^ align here!

Done.

https://codereview.chromium.org/11421141/diff/3002/chrome/browser/ui/views/un...
File chrome/browser/ui/views/uninstall_view.h (right):

https://codereview.chromium.org/11421141/diff/3002/chrome/browser/ui/views/un...
chrome/browser/ui/views/uninstall_view.h:33: bool show_delete_profile_);
On 2012/12/04 16:19:04, Ben Goodger (Google) wrote:
> no trailing underscore

Done.

[commit-bot: I haz the power, 2012-12-05 03:19:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11421141/15001

[commit-bot: I haz the power, 2012-12-05 05:46:45]

Change committed as 171173