Inform app developer what permissions are needed when APIs are rejected.

Inform app developer what permissions are needed when APIs are rejected.

[email protected]
(owner for geolocation_permission_context)

BUG=164049
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171912

[miket_OOO, 2012-12-06 23:50:52]

This is an awesome change. Thanks, LGTM.

https://codereview.chromium.org/11464013/diff/1/chrome/browser/extensions/sug...
File chrome/browser/extensions/suggest_permission_util.cc (right):

https://codereview.chromium.org/11464013/diff/1/chrome/browser/extensions/sug...
chrome/browser/extensions/suggest_permission_util.cc:31: std::string message =
base::StringPrintf(
Maybe put a comment here letting future cross-cutting developers know you've
explicitly decided not to i18n these strings (which is the right decision BTW;
it's like a log message). Or not, up to you.

Also another thing to think of might be the exact phrasing of this message.
"Consider" makes me think the runtime is telling me (politely) to do this.
Something along the "Did you mean?" lines might be more neutral (or whatever gcc
says these days with near-matches on class/struct names, it's the same idea).

The thing I'm concerned about is some clueless developer copying/pasting
dangerous code and then mechanically adding the thermonuclear_war permission
because the browser told him to. It's a pretty attenuated risk -- again, ignore
if you wish.

https://codereview.chromium.org/11464013/diff/1/chrome/browser/ui/extensions/...
File chrome/browser/ui/extensions/shell_window.cc (right):

https://codereview.chromium.org/11464013/diff/1/chrome/browser/ui/extensions/...
chrome/browser/ui/extensions/shell_window.cc:322: if
(extension_->HasAPIPermission(APIPermission::kPointerLock)) {
Now that I see this pattern a few times, can we change to a helper method that's
something like HasAPIPermissionAndSuggestInConsoleIfNot() so that future
developers are likely to use the full functionality automatically?

[scheib, 2012-12-07 18:53:04]

miket, give another look as code shifted some.

joth, owners review for
chrome/browser/geolocation/chrome_geolocation_permission_context.cc please.

https://codereview.chromium.org/11464013/diff/1/chrome/browser/extensions/sug...
File chrome/browser/extensions/suggest_permission_util.cc (right):

https://codereview.chromium.org/11464013/diff/1/chrome/browser/extensions/sug...
chrome/browser/extensions/suggest_permission_util.cc:31: std::string message =
base::StringPrintf(
On 2012/12/06 23:50:53, miket wrote:
> Maybe put a comment here letting future cross-cutting developers know you've
> explicitly decided not to i18n these strings (which is the right decision BTW;
> it's like a log message). Or not, up to you.
> 
> Also another thing to think of might be the exact phrasing of this message.
> "Consider" makes me think the runtime is telling me (politely) to do this.
> Something along the "Did you mean?" lines might be more neutral (or whatever
gcc
> says these days with near-matches on class/struct names, it's the same idea).
> 
> The thing I'm concerned about is some clueless developer copying/pasting
> dangerous code and then mechanically adding the thermonuclear_war permission
> because the browser told him to. It's a pretty attenuated risk -- again,
ignore
> if you wish.

Done.

https://codereview.chromium.org/11464013/diff/1/chrome/browser/ui/extensions/...
File chrome/browser/ui/extensions/shell_window.cc (right):

https://codereview.chromium.org/11464013/diff/1/chrome/browser/ui/extensions/...
chrome/browser/ui/extensions/shell_window.cc:322: if
(extension_->HasAPIPermission(APIPermission::kPointerLock)) {
On 2012/12/06 23:50:53, miket wrote:
> Now that I see this pattern a few times, can we change to a helper method
that's
> something like HasAPIPermissionAndSuggestInConsoleIfNot() so that future
> developers are likely to use the full functionality automatically?

Done.

[miket_OOO, 2012-12-07 18:55:45]

lgtm

https://codereview.chromium.org/11464013/diff/6001/chrome/browser/geolocation...
File chrome/browser/geolocation/chrome_geolocation_permission_context.cc
(right):

https://codereview.chromium.org/11464013/diff/6001/chrome/browser/geolocation...
chrome/browser/geolocation/chrome_geolocation_permission_context.cc:71:
profile_)) {
Now that's a good-looking change!

[commit-bot: I haz the power, 2012-12-07 20:13:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11464013/6001

[commit-bot: I haz the power, 2012-12-08 01:57:53]

Change committed as 171912