[net] Make IPEndPoint::GetFamily() return AddressFamily and add GetSockAddrFamily() to be used when…

[net] Make IPEndPoint::GetFamily() return AddressFamily and add GetSockAddrFamily() to be used when creating sockets.

BUG=126002
TEST=browse anywhere


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172768

[szym, 2012-12-12 21:05:42]

Picking up this old bug. PTAL, but if you think it's not worth it, I'll close
the bug with WontFix.

[eroman, 2012-12-12 21:19:49]

lgtm

https://codereview.chromium.org/11528012/diff/6002/net/socket/tcp_client_sock...
File net/socket/tcp_client_socket_libevent.cc (right):

https://codereview.chromium.org/11528012/diff/6002/net/socket/tcp_client_sock...
net/socket/tcp_client_socket_libevent.cc:184: int error =
CreateSocket(address.GetSockAddrFamily(), &bound_socket_);
What process did you use to find all the sites for refactor? (since methods
expecting an int for address family will silently compile when passed the enum
version).

[szym, 2012-12-12 22:47:53]

https://codereview.chromium.org/11528012/diff/6002/net/socket/tcp_client_sock...
File net/socket/tcp_client_socket_libevent.cc (right):

https://codereview.chromium.org/11528012/diff/6002/net/socket/tcp_client_sock...
net/socket/tcp_client_socket_libevent.cc:184: int error =
CreateSocket(address.GetSockAddrFamily(), &bound_socket_);
On 2012/12/12 21:19:49, eroman wrote:
> What process did you use to find all the sites for refactor? (since methods
> expecting an int for address family will silently compile when passed the enum
> version).

grep the codebase for 'GetFamily\('. I tried introducing a temporary class to
force type safety, but that does not work with switch() statements.

[commit-bot: I haz the power, 2012-12-12 22:52:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11528012/11001

[commit-bot: I haz the power, 2012-12-12 22:53:07]

Presubmit check for 11528012-11001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    jingle

Presubmit checks took 1.5s to calculate.

[szym, 2012-12-12 22:54:52]

akalin: PTAL change in jingle/

[akalin, 2012-12-12 22:59:10]

jingle LGTM

[commit-bot: I haz the power, 2012-12-12 23:01:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11528012/11001

[commit-bot: I haz the power, 2012-12-13 01:46:46]

Change committed as 172768