Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 11633052: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 2) (Closed)

Created:
8 years ago by Mike Wittman
Modified:
7 years, 11 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, jeremya+watch_chromium.org, gideonwald, ahutter, Raman Kakilate, rouslan+watch_chromium.org, melevin, benquan, benjhayden+dwatch_chromium.org, stevenjb+watch_chromium.org, samarth, dbeam+watch-autofill_chromium.org, dominich, gbillock+watch_chromium.org, chromium-apps-reviews_chromium.org, groby+watch_chromium.org, dyu1, oshima+watch_chromium.org, estade+watch_chromium.org, Albert Bodenhamer, Jered, Ilya Sherman, tfarina, sreeram, sail+watch_chromium.org, Aaron Boodman, David Black, Dane Wallinga, rdsmith+dwatch_chromium.org, smckay+watch_chromium.org, davemoore+watch_chromium.org, msw, Ben Goodger (Google)
Visibility:
Public.

Description

Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 2). See https://codereview.chromium.org/11647017/ for part 1. This performs the actual class/filename renames. No functional changes are intended in this CL. [email protected] BUG=157161 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174900

Patch Set 1 #

Patch Set 2 : make WebContentsModalDialog functions pure virtual #

Patch Set 3 : linux build fixes #

Patch Set 4 : use gtk_widget_get_toplevel for GetNativeWindow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -698 lines) Patch
M chrome/browser/chromeos/login/simple_web_view_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_danger_prompt.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 5 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/repost_form_warning_browsertest.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_tab_contents.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_control_utils.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 1 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_browsertest.mm View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/ui/constrained_window.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/constrained_window.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/ui/constrained_window_tab_helper.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/ui/constrained_window_tab_helper.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/ui/constrained_window_tab_helper_delegate.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/constrained_window_tab_helper_delegate.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/ui/constrained_window_tab_helper_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 1 6 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.cc View 1 2 3 5 chunks +23 lines, -12 lines 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_delegate.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.h View 1 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 5 chunks +18 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/web_contents_modal_dialog.h View 1 2 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/ui/web_contents_modal_dialog_manager.h View 2 chunks +23 lines, -23 lines 0 comments Download
A + chrome/browser/ui/web_contents_modal_dialog_manager.cc View 4 chunks +31 lines, -32 lines 0 comments Download
A + chrome/browser/ui/web_contents_modal_dialog_manager_delegate.h View 2 chunks +15 lines, -14 lines 0 comments Download
A + chrome/browser/ui/web_contents_modal_dialog_manager_delegate.cc View 1 chunk +8 lines, -5 lines 0 comments Download
A + chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc View 1 1 chunk +25 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Mike Wittman
8 years ago (2012-12-21 01:55:33 UTC) #1
sky
LGTM
8 years ago (2012-12-21 15:27:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11633052/73
8 years ago (2012-12-22 20:24:18 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-22 20:45:22 UTC) #4
Mike Wittman
Hi Elliot, can you look at the GTK bits of this, and the implementation of ...
7 years, 11 months ago (2013-01-02 22:24:50 UTC) #5
Elliot Glaysher
On 2013/01/02 22:24:50, Mike Wittman wrote: > Hi Elliot, can you look at the GTK ...
7 years, 11 months ago (2013-01-02 22:31:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11633052/22001
7 years, 11 months ago (2013-01-02 22:48:13 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-03 00:42:01 UTC) #8
Message was sent while issue was closed.
Change committed as 174900

Powered by Google App Engine
This is Rietveld 408576698