Remove PrefValueStore's dependency on PrefModelAssociator.

Remove PrefValueStore's dependency on PrefModelAssociator.

[email protected]
BUG=155525
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174680

[Jói, 2012-12-19 15:45:54]

Hi Mattias,

This is a follow-up to the big change
(https://codereview.chromium.org/11636018/) so lower priority than completing
that review.

Your opinion on whether it would be OK to send the notification through the
PrefNotifier instead of allowing to directly set a callback on PrefValueStore
would be appreciated.  I figured this approach, which means no filtering by any
class outside of PrefValueStore, might be safer, but I'm unsure.

Cheers,
Jói

[Mattias Nissler (ping if slow), 2012-12-20 16:00:55]

This approach is definitely the safer option. I think ultimately I'd like to see
the sync associator to talk to interact with PrefService::user_pref_store_
exclusively. Sync is only concerned with pref values that are set by the user
(in particular, it should ignore command-line overrides, policy, extension
overrides etc. which currently requires explicit checks in PrefModelAssociator).
Therefore, changing PrefModelAssociator to read/write from/to user_pref_store_
and observe it for changes would be cleaner overall.

https://codereview.chromium.org/11636018/diff/1/chrome/browser/prefs/pref_val...
File chrome/browser/prefs/pref_value_store.h (right):

https://codereview.chromium.org/11636018/diff/1/chrome/browser/prefs/pref_val...
chrome/browser/prefs/pref_value_store.h:244: PrefChangedCallback callback_;
should have a better variable name.

[Jói, 2012-12-20 16:52:49]

https://codereview.chromium.org/11636018/diff/1/chrome/browser/prefs/pref_val...
File chrome/browser/prefs/pref_value_store.h (right):

https://codereview.chromium.org/11636018/diff/1/chrome/browser/prefs/pref_val...
chrome/browser/prefs/pref_value_store.h:244: PrefChangedCallback callback_;
On 2012/12/20 16:00:56, Mattias Nissler wrote:
> should have a better variable name.

Changed to pref_changed_callback_.

[Mattias Nissler (ping if slow), 2012-12-20 17:19:51]

LGTM for the time being :)

[commit-bot: I haz the power, 2012-12-27 10:15:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11636018/14001

[commit-bot: I haz the power, 2012-12-27 13:11:57]

Change committed as 174680