Integrate QUIC info into net-internals.

Integrate QUIC info into net-internals.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175239

[Ryan Hamilton, 2013-01-03 21:25:33]

On 2012/12/28 22:12:51, Ryan Hamilton wrote:

ping

[eroman, 2013-01-04 00:16:14]

LGTM.

Apologies for delay, was on vacation :)

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
File chrome/browser/resources/net_internals/quic_view.js (right):

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
chrome/browser/resources/net_internals/quic_view.js:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
2013 now :)

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
chrome/browser/resources/net_internals/quic_view.js:6: * This view displays a
summary of the state of each QUIC sessions, and
something doesn't sound right here...

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
chrome/browser/resources/net_internals/quic_view.js:56: * If |quicInfo| there
are any sessions, display a single table with
doesn't sound right.

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
chrome/browser/resources/net_internals/quic_view.js:63: (quicInfo == null ||
quicInfo.sessions == null ||
Rather than testing null, i suggest doing a boolean test, i.e:
  !quickInfo || !quickInfo.sessions

(that way it is less permissive on data that may be coming from a log).

https://codereview.chromium.org/11696010/diff/1/net/quic/quic_client_session.cc
File net/quic/quic_client_session.cc (right):

https://codereview.chromium.org/11696010/diff/1/net/quic/quic_client_session....
net/quic/quic_client_session.cc:110: //dict->SetInteger("source_id",
net_log_.source().id);
If unused, then delete this line.

[Ryan Hamilton, 2013-01-04 02:56:05]

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
File chrome/browser/resources/net_internals/quic_view.js (right):

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
chrome/browser/resources/net_internals/quic_view.js:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2013/01/04 00:16:14, eroman wrote:
> 2013 now :)

Hah!  Done.

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
chrome/browser/resources/net_internals/quic_view.js:6: * This view displays a
summary of the state of each QUIC sessions, and
On 2013/01/04 00:16:14, eroman wrote:
> something doesn't sound right here...

Done.

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
chrome/browser/resources/net_internals/quic_view.js:56: * If |quicInfo| there
are any sessions, display a single table with
On 2013/01/04 00:16:14, eroman wrote:
> doesn't sound right.

Done.

https://codereview.chromium.org/11696010/diff/1/chrome/browser/resources/net_...
chrome/browser/resources/net_internals/quic_view.js:63: (quicInfo == null ||
quicInfo.sessions == null ||
On 2013/01/04 00:16:14, eroman wrote:
> Rather than testing null, i suggest doing a boolean test, i.e:
>   !quickInfo || !quickInfo.sessions
> 
> (that way it is less permissive on data that may be coming from a log).

Done.

https://codereview.chromium.org/11696010/diff/1/net/quic/quic_client_session.cc
File net/quic/quic_client_session.cc (right):

https://codereview.chromium.org/11696010/diff/1/net/quic/quic_client_session....
net/quic/quic_client_session.cc:110: //dict->SetInteger("source_id",
net_log_.source().id);
On 2013/01/04 00:16:14, eroman wrote:
> If unused, then delete this line.

Done.

[commit-bot: I haz the power, 2013-01-04 03:09:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11696010/10017

[Ryan Hamilton, 2013-01-04 03:13:09]

On 2013/01/04 00:16:14, eroman wrote:
> LGTM.
> 
> Apologies for delay, was on vacation :)

Oh man.  I forgot about that.   Sorry for pestering you so soon.

[commit-bot: I haz the power, 2013-01-04 05:37:22]

Retried try job too often on linux_chromeos for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-04 19:08:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11696010/7002

[commit-bot: I haz the power, 2013-01-04 21:49:43]

Retried try job too often on linux_chromeos for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-04 22:41:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11696010/7002

[commit-bot: I haz the power, 2013-01-05 00:31:36]

Change committed as 175239