LoadTiming in net, part 3.

LoadTiming in net, part 3.

Add send and receive times to HttpNetworkTransaction.

Add LoadTimingInfo accessors to Http*Transaction,
URLRequestJob, and URLRequest classes.

Proxy resolution times still need to be added.

BUG=77446
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177942

[mmenke, 2013-01-18 17:20:14]

Keep on getting sidetracked on these...  Have all the non-test code written and
working, just keep on getting sidetracked from working on the tests.

Getting back to reviewing your PAC CL after lunch, honest! :)

[eroman, 2013-01-19 01:05:56]

LGTM. Nice work on the testing! The timings are quite important for our metrics,
so I appreciated all the tests you have added.

https://codereview.chromium.org/11929017/diff/14021/net/http/http_network_tra...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/11929017/diff/14021/net/http/http_network_tra...
net/http/http_network_transaction.cc:389: const SSLConfig& used_ssl_config,
It doesn't look like anything changed here other than formatting right?

https://codereview.chromium.org/11929017/diff/14021/net/http/http_network_tra...
File net/http/http_network_transaction_spdy3_unittest.cc (right):

https://codereview.chromium.org/11929017/diff/14021/net/http/http_network_tra...
net/http/http_network_transaction_spdy3_unittest.cc:1624: 
nit: delete extra line.

https://codereview.chromium.org/11929017/diff/14021/net/http/http_transaction.h
File net/http/http_transaction.h (right):

https://codereview.chromium.org/11929017/diff/14021/net/http/http_transaction...
net/http/http_transaction.h:116: // |load_timing| must have all null times when
called.  Returns NULL and does
|load_timing_info|, or rename the argument. Also, change "Returns NULL", since
return type is a bool.

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
File net/url_request/url_request.cc (right):

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
net/url_request/url_request.cc:375: // Downstream functions all expect
|load_timing| to have null times.
|load_timing_info| or change argument.

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
File net/url_request/url_request_job.cc (right):

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
net/url_request/url_request_job.cc:121: // Only certain request types return
more han just request start times.
typo: han

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
File net/url_request/url_request_test_util.h (right):

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
net/url_request/url_request_test_util.h:289: bool has_load_timing_info_;
should these new bools be initialized in the constructor?

[mmenke, 2013-01-19 01:37:15]

Thanks for the feedback!

https://codereview.chromium.org/11929017/diff/14021/net/http/http_network_tra...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/11929017/diff/14021/net/http/http_network_tra...
net/http/http_network_transaction.cc:389: const SSLConfig& used_ssl_config,
On 2013/01/19 01:05:56, eroman wrote:
> It doesn't look like anything changed here other than formatting right?

You are correct.  Change undone.  It was part of the proxy resolution change,
though I'm thinking of reworking it.

https://codereview.chromium.org/11929017/diff/14021/net/http/http_network_tra...
File net/http/http_network_transaction_spdy3_unittest.cc (right):

https://codereview.chromium.org/11929017/diff/14021/net/http/http_network_tra...
net/http/http_network_transaction_spdy3_unittest.cc:1624: 
On 2013/01/19 01:05:56, eroman wrote:
> nit: delete extra line.

Done (In both files).

https://codereview.chromium.org/11929017/diff/14021/net/http/http_transaction.h
File net/http/http_transaction.h (right):

https://codereview.chromium.org/11929017/diff/14021/net/http/http_transaction...
net/http/http_transaction.h:116: // |load_timing| must have all null times when
called.  Returns NULL and does
On 2013/01/19 01:05:56, eroman wrote:
> |load_timing_info|, or rename the argument. Also, change "Returns NULL", since
> return type is a bool.

Done and done.

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
File net/url_request/url_request.cc (right):

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
net/url_request/url_request.cc:375: // Downstream functions all expect
|load_timing| to have null times.
On 2013/01/19 01:05:56, eroman wrote:
> |load_timing_info| or change argument.

Done.

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
File net/url_request/url_request_job.cc (right):

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
net/url_request/url_request_job.cc:121: // Only certain request types return
more han just request start times.
On 2013/01/19 01:05:56, eroman wrote:
> typo: han

Done (than)

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
File net/url_request/url_request_test_util.h (right):

https://codereview.chromium.org/11929017/diff/14021/net/url_request/url_reque...
net/url_request/url_request_test_util.h:289: bool has_load_timing_info_;
On 2013/01/19 01:05:56, eroman wrote:
> should these new bools be initialized in the constructor?

Done.  Thanks for catching this!  Using scoped_ptrs everywhere spoils me.  :)

[mmenke, 2013-01-19 01:40:55]

[+erikwright] Please review the chrome_frame change, thanks!

[erikwright (departed), 2013-01-21 16:22:02]

chrome_frame/ LGTM.

[commit-bot: I haz the power, 2013-01-21 16:39:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11929017/9038

[commit-bot: I haz the power, 2013-01-21 18:23:26]

Change committed as 177942