Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 11959039: Land recent QUIC changes (Closed)

Created:
7 years, 11 months ago by Ryan Hamilton
Modified:
7 years, 11 months ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Cleaning up constructors for QuicData, QuicPacket and QuicEncryptedPacket to not take unnamed bool values. Merge internal change: 41194576 Simplify the interface between the QuicConnection and the congestion control system. Add a QuicCongestionManager to wrap the the SendScheduler and ReceiptMetricsCollector in a single class for all congestion-related functionality. (Narrows the SendScheduler-specific interface to just those methods called by the QuicConnection.) This is a minor cleanup in advance of moving the RTO management out of QuicConnection (since it is algorithm specific). Merge internal change: 41188949 Refactor SendStreamData to frame one StreamFrame at once and send it, instea d of framing and serializing multiple in DataToStream. Merge internal change: 41155771 Expand the 48 bit on-the-wire packet sequence number into the full 64 bit se quence number. Merge internal change: 41147680 Enable encryption of private flags. Merge internal change: 41147034 Splitting flags into private and public and implementing framing for both. Merge internal change: 41145985 Add a zero length padding frame. Merge internal change: 41141396 Remove "support" for PDUs Merge internal change: 41133537 Remove the Clear method from QuicPacketCreator options, and explicitly initialize all field in the constructor. Merge internal change: 41128100 Cleanup from chrome cl 11820003 Merge internal change: 41118012 Refactor to pull out connection close so that connection can be closed without sending connection close frame. Merge internal change: 41026182 Keep a bool to check if a QuicPacket is an FEC packet instead of taking whol e packet flag as an input to the constructor. Merge internal change: 41026127 Remove default constructors for QuicTime and QuicTime::Delta and used static Zero() methods instead to make it clear what value is being used. One annoying side-effect is this means that maps which have these objects as keys can't not be accessed with []. Thankfully, this is not a huge problem. (It only affects us in one place). But I can add the default constructors back to support this use case, if necessary. (I'd prefer not to since I think Zero() is more clear, but can go either way). Merge internal change: 40993340 Replace boolean literals with named constants ini QuicConnection::SendPacket() calls. Merge internal change: 40991762 Consistently use Retransmit/Retransmission (instead of Resend) when talking about sending QUIC data a second time (in a new packet). Merge internal change: 40988697 Move the logic for RTO timeout handling from the Helper to the QuicConnection. Merge internal change: 40980852 Fixing a bug where a non-existant frame corresponding to an FEC was being deleted. Merge internal change: 40883214 Change the QUIC FEC group number from an ad-hoc id to the sequence number of the first packet in the group. Over the wire, however, send a 1 byte delta from the sequence number of the current packet to the sequence number of the first protected packet in the group. Merge internal change: 40881017 [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177612

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Copyright #

Patch Set 4 : Signed/Unsigned #

Patch Set 5 : android?!? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1537 lines, -938 lines) Patch
M net/net.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/congestion_control/cubic.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/congestion_control/fix_rate_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/hybrid_slow_start.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/quic/congestion_control/leaky_bucket.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/paced_sender_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
A net/quic/congestion_control/quic_congestion_manager.h View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
A net/quic/congestion_control/quic_congestion_manager.cc View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M net/quic/congestion_control/quic_receipt_metrics_collector.h View 1 chunk +7 lines, -8 lines 0 comments Download
M net/quic/congestion_control/quic_receipt_metrics_collector_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/quic_send_scheduler.h View 1 chunk +8 lines, -8 lines 0 comments Download
M net/quic/congestion_control/quic_send_scheduler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/congestion_control/quic_send_scheduler_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M net/quic/congestion_control/tcp_receiver_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/crypto_protocol.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M net/quic/quic_connection.h View 1 10 chunks +60 lines, -43 lines 0 comments Download
M net/quic/quic_connection.cc View 1 33 chunks +159 lines, -94 lines 0 comments Download
M net/quic/quic_connection_helper.h View 1 3 chunks +7 lines, -8 lines 0 comments Download
M net/quic/quic_connection_helper.cc View 1 6 chunks +12 lines, -54 lines 0 comments Download
M net/quic/quic_connection_helper_test.cc View 1 8 chunks +20 lines, -17 lines 0 comments Download
M net/quic/quic_connection_test.cc View 24 chunks +57 lines, -51 lines 0 comments Download
M net/quic/quic_data_writer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_data_writer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_fec_group.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/quic_fec_group.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M net/quic/quic_fec_group_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_framer.h View 4 chunks +25 lines, -2 lines 0 comments Download
M net/quic/quic_framer.cc View 22 chunks +182 lines, -70 lines 0 comments Download
M net/quic/quic_framer_test.cc View 40 chunks +444 lines, -159 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/quic_packet_creator.h View 3 chunks +28 lines, -26 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 5 chunks +63 lines, -99 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 1 2 3 4 3 chunks +80 lines, -159 lines 0 comments Download
M net/quic/quic_protocol.h View 1 2 3 11 chunks +104 lines, -42 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/quic_session.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 3 chunks +9 lines, -6 lines 0 comments Download
M net/quic/quic_time.h View 2 chunks +7 lines, -6 lines 0 comments Download
M net/quic/quic_time.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M net/quic/quic_time_test.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/test_tools/mock_clock.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11959039/1
7 years, 11 months ago (2013-01-17 19:05:43 UTC) #1
commit-bot: I haz the power
Failed to apply patch for net/quic/quic_connection_helper.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 11 months ago (2013-01-17 19:06:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11959039/4001
7 years, 11 months ago (2013-01-17 19:32:26 UTC) #3
commit-bot: I haz the power
Presubmit check for 11959039-4001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-17 19:32:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11959039/8001
7 years, 11 months ago (2013-01-17 19:42:00 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on android_dbg HTTP Error 400: Bad Request
7 years, 11 months ago (2013-01-17 20:08:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11959039/22001
7 years, 11 months ago (2013-01-17 20:09:14 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) build
7 years, 11 months ago (2013-01-17 20:53:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11959039/36001
7 years, 11 months ago (2013-01-17 23:09:02 UTC) #9
jar (doing other things)
Since I think I reviewed all the underlying CLs.... LGTM. Thanks again for splitting them ...
7 years, 11 months ago (2013-01-18 02:18:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11959039/36001
7 years, 11 months ago (2013-01-18 02:53:48 UTC) #11
commit-bot: I haz the power
7 years, 11 months ago (2013-01-18 05:43:22 UTC) #12
Message was sent while issue was closed.
Change committed as 177612

Powered by Google App Engine
This is Rietveld 408576698