Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
11968055:
[about:flags] Disable flags on Android (Closed)
|
Created:
7 years, 11 months ago by gone Modified:
7 years, 11 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
Description[about:flags] Disable flags on Android
Disable some flags that don't make sense for Android (e.g. NaCl).
BUG=170406
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178366
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressing comments #
Total comments: 29
Patch Set 3 : Addressing srikanth's #
Total comments: 8
Patch Set 4 : aelias' removals #Patch Set 5 : weird mismatch #
Total comments: 10
Patch Set 6 : beverloo's #
Total comments: 2
Patch Set 7 : Re-disabling long tap for Android #Patch Set 8 : Rebase #Messages
Total messages: 18 (0 generated)
https://chromiumcodereview.appspot.com/11968055/diff/1/chrome/browser/about_f... File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/11968055/diff/1/chrome/browser/about_f... chrome/browser/about_flags.cc:416: kOsWin | kOsMac | kOsLinux | kOsCrOS, Define kOsDesktop = win | mac | linux | cros above and use this in all the places you've changed.
https://chromiumcodereview.appspot.com/11968055/diff/1/chrome/browser/about_f... File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/11968055/diff/1/chrome/browser/about_f... chrome/browser/about_flags.cc:416: kOsWin | kOsMac | kOsLinux | kOsCrOS, On 2013/01/17 22:47:37, Nico wrote: > Define kOsDesktop = win | mac | linux | cros above and use this in all the > places you've changed. Done.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11968055/5001
Added a few more. Also peter@/vinodkr@ for OWP flags and aelias@ for graphics flags https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:510: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:543: kOsAll, desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:644: kOsAll, desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:651: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:745: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:761: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:768: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:847: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:906: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:913: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:927: kOsAll, desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:1027: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:1120: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:1127: kOsAll, Desktop https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:1232: kOsAll, Desktop
Disabled the ones you mentioned that made sense. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:510: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:543: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:644: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:651: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:745: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:761: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:768: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:847: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:906: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop We don't use Ash. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:913: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Ditto. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:927: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > desktop Double ditto. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:1027: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:1120: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/5001/chrome/browser/abou... chrome/browser/about_flags.cc:1127: kOsAll, On 2013/01/17 23:22:40, srikanth wrote: > Desktop Done.
https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... chrome/browser/about_flags.cc:321: "force-compositing-mode-2", Desktop https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... chrome/browser/about_flags.cc:328: "threaded-compositing-mode", Desktop https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... chrome/browser/about_flags.cc:377: "disable-gpu-vsync", Desktop https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... chrome/browser/about_flags.cc:779: "touch-events", Desktop
https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... chrome/browser/about_flags.cc:321: "force-compositing-mode-2", On 2013/01/18 00:15:21, aelias wrote: > Desktop Doesn't affect us https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... chrome/browser/about_flags.cc:328: "threaded-compositing-mode", On 2013/01/18 00:15:21, aelias wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... chrome/browser/about_flags.cc:377: "disable-gpu-vsync", On 2013/01/18 00:15:21, aelias wrote: > Desktop Done. https://chromiumcodereview.appspot.com/11968055/diff/18001/chrome/browser/abo... chrome/browser/about_flags.cc:779: "touch-events", On 2013/01/18 00:15:21, aelias wrote: > Desktop Done.
Thanks for doing this, looks good overall! https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:554: "enable-gesture-tap-highlight", We force gesture tap highlights on. Should we use "SINGLE_VALUE_TYPE("")" for Android to make sure it doesn't show up? https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:644: kOsDesktop, We can't we disable this for Android? The API is enabled by default. https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:658: kOsAll, Has anyone verified that Opus playback works on Android? https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:1051: SINGLE_VALUE_TYPE(switches::kEnableWebAudioInput), We don't ship the Web Audio API yet so this will be a void until we do. https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:1204: kOsWin | kOsCrOS, Do we need this as part of r177331? We are emitting LongTaps now.
https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:554: "enable-gesture-tap-highlight", On 2013/01/18 15:10:20, Peter Beverloo wrote: > We force gesture tap highlights on. Should we use "SINGLE_VALUE_TYPE("")" for > Android to make sure it doesn't show up? I think SINGLE_VALUE_TYPE("") is only used when the command line switch isn't compiled in. Just avoiding putting kOsAndroid on the line should be good enough to stop it from happening. https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:644: kOsDesktop, On 2013/01/18 15:10:20, Peter Beverloo wrote: > We can't we disable this for Android? The API is enabled by default. Overriding Srikanth and turning it back on. https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:658: kOsAll, On 2013/01/18 15:10:20, Peter Beverloo wrote: > Has anyone verified that Opus playback works on Android? Disabling flag until someone has. https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:1051: SINGLE_VALUE_TYPE(switches::kEnableWebAudioInput), On 2013/01/18 15:10:20, Peter Beverloo wrote: > We don't ship the Web Audio API yet so this will be a void until we do. Replaced with kOsDesktop until then. https://chromiumcodereview.appspot.com/11968055/diff/2003/chrome/browser/abou... chrome/browser/about_flags.cc:1204: kOsWin | kOsCrOS, On 2013/01/18 15:10:20, Peter Beverloo wrote: > Do we need this as part of r177331? We are emitting LongTaps now. No idea what this flag does, but I've allowed turning it on since it looks like that CL did land yesterday.
Ping to everyone who asked for changes. Is this clear to re-land again?
Thx for incorporating all the changes. One minor suggestion but LGTM otherwise. https://chromiumcodereview.appspot.com/11968055/diff/2004/chrome/browser/abou... File chrome/browser/about_flags.cc (left): https://chromiumcodereview.appspot.com/11968055/diff/2004/chrome/browser/abou... chrome/browser/about_flags.cc:1204: SINGLE_VALUE_TYPE(switches::kEnableTouchDragDrop) I would leave this to kOSWin | kOsCros unless someone has explicitly tested this on Android.
Any other requests? https://chromiumcodereview.appspot.com/11968055/diff/2004/chrome/browser/abou... File chrome/browser/about_flags.cc (left): https://chromiumcodereview.appspot.com/11968055/diff/2004/chrome/browser/abou... chrome/browser/about_flags.cc:1204: SINGLE_VALUE_TYPE(switches::kEnableTouchDragDrop) On 2013/01/22 18:47:15, srikanth1 wrote: > I would leave this to kOSWin | kOsCros unless someone has explicitly tested this > on Android. Re-disabled after talking with beverloo.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11968055/27001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11968055/31002
Message was sent while issue was closed.
Change committed as 178366 |
