Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12038056: Remove GetActiveWebContents from browser_tabstrip. (Closed)

Created:
7 years, 11 months ago by Avi (use Gerrit)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, groby+watch_chromium.org, benjhayden+dwatch_chromium.org, tfarina, sail+watch_chromium.org, Aaron Boodman, scheib+watch_chromium.org, rdsmith+dwatch_chromium.org, chromium-apps-reviews_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org
Visibility:
Public.

Description

Remove GetActiveWebContents from browser_tabstrip. BUG=167548 TEST=no functional change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179466

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -64 lines) Patch
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/browser_action_apitest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/intents/native_services_browsertest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/net/websocket_browsertest.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_close_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_tabstrip.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 11 chunks +25 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
7 years, 11 months ago (2013-01-24 02:39:26 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 10 months ago (2013-01-28 17:32:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12038056/3001
7 years, 10 months ago (2013-01-29 21:14:23 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-01-29 23:47:07 UTC) #4
Message was sent while issue was closed. 
Change committed as 179466

Powered by Google App Engine
This is Rietveld 408576698