Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 12040086: Test to make sure a unparented control gets moved to another root window (Closed)

Created:
7 years, 11 months ago by oshima
Modified:
7 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Test to make sure a unparented control gets moved to another root window when a display is disconnected. BUG=171908 TEST=coverted by test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179017

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M ash/root_window_controller_unittest.cc View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
and here is the test. I'll land this after the other CL. root_window_controller.cc change is ...
7 years, 11 months ago (2013-01-24 23:24:53 UTC) #1
James Cook
LGTM with optional suggestion https://codereview.chromium.org/12040086/diff/1/ash/root_window_controller_unittest.cc File ash/root_window_controller_unittest.cc (right): https://codereview.chromium.org/12040086/diff/1/ash/root_window_controller_unittest.cc#newcode174 ash/root_window_controller_unittest.cc:174: EXPECT_EQ(root_windows[1], I assume it goes ...
7 years, 11 months ago (2013-01-25 00:20:07 UTC) #2
oshima
https://codereview.chromium.org/12040086/diff/1/ash/root_window_controller_unittest.cc File ash/root_window_controller_unittest.cc (right): https://codereview.chromium.org/12040086/diff/1/ash/root_window_controller_unittest.cc#newcode174 ash/root_window_controller_unittest.cc:174: EXPECT_EQ(root_windows[1], On 2013/01/25 00:20:07, James Cook (Chromium) wrote: > ...
7 years, 11 months ago (2013-01-25 00:27:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12040086/4001
7 years, 11 months ago (2013-01-25 08:27:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12040086/4001
7 years, 11 months ago (2013-01-26 00:55:23 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-26 03:58:38 UTC) #6
Message was sent while issue was closed.
Change committed as 179017

Powered by Google App Engine
This is Rietveld 408576698