Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12066003: Remove TabStripModel wrapper use. (Closed)

Created:
7 years, 11 months ago by Avi (use Gerrit)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, browser-components-watch_chromium.org, gideonwald, dcheng, ajwong+watch_chromium.org, melevin, benjhayden+dwatch_chromium.org, dominich, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), Avi (use Gerrit), creis+watch_chromium.org, rdsmith+dwatch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, pam+watch_chromium.org, yoshiki+watch_chromium.org, haitaol1, Jered, akalin, feature-media-reviews_chromium.org, tfarina, sreeram, sail+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, David Black, samarth+watch_chromium.org, mmenke
Visibility:
Public.

Description

Remove TabStripModel wrapper use. BUG=167548 TEST=no functional change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179254

Patch Set 1 #

Patch Set 2 : gtk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -267 lines) Patch
M chrome/browser/chrome_main_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 12 chunks +21 lines, -13 lines 0 comments Download
M chrome/browser/download/download_shelf.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarms_api_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_action_apitest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/script_badge_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/chrome_app_api_browsertest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 6 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_dom_clipboard_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_icon_source_apitest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_url_rewrite_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/page_action_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/web_contents_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_standalone_install_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 9 chunks +17 lines, -11 lines 0 comments Download
M chrome/browser/history/multipart_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 1 7 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/loadtimes_extension_bindings_browsertest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/managed_mode/managed_mode_browsertest.cc View 14 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/mouseleave_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/net/load_timing_observer_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/net/proxy_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/page_cycler/page_cycler_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prefetch_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 39 chunks +56 lines, -42 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 9 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_browsertest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_browsertest.mm View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk_browsertest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 18 chunks +34 lines, -18 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/web_dialog_view_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/unload_browsertest.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
7 years, 11 months ago (2013-01-24 01:26:52 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 10 months ago (2013-01-28 17:31:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12066003/1
7 years, 10 months ago (2013-01-28 22:02:26 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-28 22:41:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12066003/12002
7 years, 10 months ago (2013-01-28 22:52:14 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-01-29 01:50:51 UTC) #6
Message was sent while issue was closed. 
Change committed as 179254

Powered by Google App Engine
This is Rietveld 408576698