Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 12079111: Allow separately blacklisting Stage3D baseline mode. (Closed)

Created:
7 years, 10 months ago by jbauman
Modified:
7 years, 10 months ago
Reviewers:
Zhenyao Mo, brettw, jschuh
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Allow separately blacklisting Stage3D baseline mode. Some older drivers should support Stage3D constrained mode, not baseline mode, so add blacklist entries for that. BUG=172771 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181836

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -6 lines) Patch
M content/browser/gpu/gpu_blacklist.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_util.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/resources/gpu/info_view.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/gpu_feature_type.h View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/api/private/ppb_flash.idl View 1 chunk +9 lines, -1 line 0 comments Download
M ppapi/c/private/ppb_flash.h View 2 chunks +9 lines, -2 lines 0 comments Download
M ppapi/proxy/flash_resource.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_preferences.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbauman
7 years, 10 months ago (2013-02-05 21:52:58 UTC) #1
zmo
On 2013/02/05 21:52:58, jbauman wrote: LGTM
7 years, 10 months ago (2013-02-05 21:54:51 UTC) #2
jbauman
Brett, could you do an OWNERS review on this?
7 years, 10 months ago (2013-02-05 22:00:35 UTC) #3
brettw
lgtm
7 years, 10 months ago (2013-02-06 18:53:37 UTC) #4
jbauman
Also, jschuh@, could you do an OWNERS review on ppapi/proxy/ppapi_messages.h ?
7 years, 10 months ago (2013-02-12 00:01:28 UTC) #5
jschuh
No new attack surface and it's just adding a bool. So, rubberstamp lgtm.
7 years, 10 months ago (2013-02-12 00:33:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12079111/2001
7 years, 10 months ago (2013-02-12 00:46:33 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/gpu_internals/info_view.js: While running patch -p1 --forward --force --no-backup-if-mismatch; A chrome/browser/resources/gpu_internals ...
7 years, 10 months ago (2013-02-12 00:46:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12079111/19001
7 years, 10 months ago (2013-02-12 01:08:02 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 03:45:55 UTC) #10
Message was sent while issue was closed.
Change committed as 181836

Powered by Google App Engine
This is Rietveld 408576698