SPDY - DeterministicSocketData - Fix to handle Async Read/write

SPDY - DeterministicSocketData - Fix to handle Async Read/write followed by
Sync read/write.

[email protected]
TEST=network unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179864

[ramant (doing other things), 2013-01-31 02:53:23]

Hi Ryan,
  This CL has the changes we both have worked on. Moved the NextStep before we
call CompleteRead(), CompleteWrite(). Added is_running_ to Run() method is not
being reentered.

[Ryan Hamilton, 2013-01-31 02:58:58]

Looks good.  Couple of naming nits.

https://codereview.chromium.org/12096055/diff/9001/net/socket/deterministic_s...
File net/socket/deterministic_socket_data_unittest.cc (right):

https://codereview.chromium.org/12096055/diff/9001/net/socket/deterministic_s...
net/socket/deterministic_socket_data_unittest.cc:172: void
DeterministicSocketDataTest::ReadCallback(int len, int rv) {
nit: Can you pick a better name for this?  RecursiveReadCallback, or
ReentrantReadCallback, or something?  (Ditto below)

https://codereview.chromium.org/12096055/diff/9001/net/socket/deterministic_s...
net/socket/deterministic_socket_data_unittest.cc:317:
TEST_F(DeterministicSocketDataTest, MixedReadsAsyncSync) {
nit: Test should be named SyncReadFromCompletionCallback, I think.

https://codereview.chromium.org/12096055/diff/9001/net/socket/deterministic_s...
net/socket/deterministic_socket_data_unittest.cc:457:
TEST_F(DeterministicSocketDataTest, MixedWritesAsyncSync) {
nit: Test should be named SyncWriteFromCompletionCallback, I think.

[ramant (doing other things), 2013-01-31 03:10:52]

https://codereview.chromium.org/12096055/diff/9001/net/socket/deterministic_s...
File net/socket/deterministic_socket_data_unittest.cc (right):

https://codereview.chromium.org/12096055/diff/9001/net/socket/deterministic_s...
net/socket/deterministic_socket_data_unittest.cc:172: void
DeterministicSocketDataTest::ReadCallback(int len, int rv) {
On 2013/01/31 02:58:58, Ryan Hamilton wrote:
> nit: Can you pick a better name for this?  RecursiveReadCallback, or
> ReentrantReadCallback, or something?  (Ditto below)

Done.

https://codereview.chromium.org/12096055/diff/9001/net/socket/deterministic_s...
net/socket/deterministic_socket_data_unittest.cc:317:
TEST_F(DeterministicSocketDataTest, MixedReadsAsyncSync) {
On 2013/01/31 02:58:58, Ryan Hamilton wrote:
> nit: Test should be named SyncReadFromCompletionCallback, I think.

Done.

https://codereview.chromium.org/12096055/diff/9001/net/socket/deterministic_s...
net/socket/deterministic_socket_data_unittest.cc:457:
TEST_F(DeterministicSocketDataTest, MixedWritesAsyncSync) {
On 2013/01/31 02:58:58, Ryan Hamilton wrote:
> nit: Test should be named SyncWriteFromCompletionCallback, I think.

Done.

[Ryan Hamilton, 2013-01-31 03:12:35]

lgtm

[commit-bot: I haz the power, 2013-01-31 03:13:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12096055/15001

[commit-bot: I haz the power, 2013-01-31 11:47:34]

Change committed as 179864