Remove syncer::IncomingInvalidationSource

Remove syncer::IncomingInvalidationSource

Since we separated local and remote invalidations in r179546, we no
longer need to differentiate between the two sources with an enum.  The
IncomingInvalidationSource is always REMOTE_INVALIDATION.

This commit removes the IncomingInvalidationSource enum and the
'source' parameter that was part of the invalidator callback API.  The
callees can now safely assume that all invalidations have a 'remote'
source.

BUG=124143
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180213

[rlarocque, 2013-01-30 19:45:53]

This patch contains a lot of trivial changes in a lot of subsystems.

dcheng: Please review chrome/browser/extensions/api/push_messaging.
kochi: Please review chrome/browser/chromeos/drive.
msw: I've added you as an FYI for the trivial changes in
chrome/browser/chrome_to_mobile_service.*
ben: Please review chrome/browser/chrome_to_mobile_service.*, since those files
are owned by chrome/OWNERS.
zea: Please review everything else.

[msw, 2013-01-30 19:49:29]

chrome/browser/chrome_to_mobile_service.* LGTM

[dcheng, 2013-01-30 19:57:45]

push_messaging lgtm

[kochi, 2013-01-31 01:56:43]

chromeos/drive LGTM

[Ben Goodger (Google), 2013-01-31 16:58:10]

lgtm

[Nicolas Zea, 2013-01-31 20:04:22]

LGTM

https://chromiumcodereview.appspot.com/12114012/diff/9041/sync/notifier/inval...
File sync/notifier/invalidation_notifier_unittest.cc (right):

https://chromiumcodereview.appspot.com/12114012/diff/9041/sync/notifier/inval...
sync/notifier/invalidation_notifier_unittest.cc:73: // None of the tests
actually care about |source|.
remove comment.

[rlarocque, 2013-01-31 20:32:21]

I think that's everyone.  Thanks for the reviews.

https://chromiumcodereview.appspot.com/12114012/diff/9041/sync/notifier/inval...
File sync/notifier/invalidation_notifier_unittest.cc (right):

https://chromiumcodereview.appspot.com/12114012/diff/9041/sync/notifier/inval...
sync/notifier/invalidation_notifier_unittest.cc:73: // None of the tests
actually care about |source|.
On 2013/01/31 20:04:22, Nicolas Zea wrote:
> remove comment.

Good catch.  Fixed.

[commit-bot: I haz the power, 2013-01-31 20:33:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12114012/3005

[commit-bot: I haz the power, 2013-02-01 23:30:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12114012/3005

[commit-bot: I haz the power, 2013-02-02 00:24:50]

Change committed as 180213