Files.app: show the warning message when drive authentication is failed

Files.app: show the warning message when drive authentication is failed.

When authentication is failed on drive, files.app goes offline-mode. This patch adds message to notify that drive is unreachable and encourage user to log out. 

Major changes: 
- Add the private API to logout (fileBrowserPrivate.logout).
- Add the message "Google Drive could not be reached. Please <log out> and log back in."(IDS_FILE_BROWSER_DRIVE_NOT_REACHED).
- Show this message when |OnRefreshKeyInvalid()| is observed.

BUG=160486
TEST=Clear refresh token on drive-internals, and confirm the offline-mode message shows.

[email protected], [email protected]
[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183071

[yoshiki, 2013-02-07 00:15:08]

@kinaba, could you take a look? thanks,

[kinaba, 2013-02-07 04:30:26]

On 2013/02/07 00:15:08, yoshiki wrote:
> @kinaba, could you take a look? thanks,

code change looks good,  but could you be more explicit in the patch
description,
message text, and the message text ID name (DRIVE_NOT_REACHED)? We don't want
to (and don't indeed) warn user when it is in the real 'offline' status with
disconnected
network. I think we should be better to tell that authentication is failed here,
not just
'unreachable'.

[yoshiki, 2013-02-07 10:31:16]

On 2013/02/07 04:30:26, kinaba wrote:
> On 2013/02/07 00:15:08, yoshiki wrote:
> > @kinaba, could you take a look? thanks,
> 
> code change looks good,  but could you be more explicit in the patch
> description,
> message text, and the message text ID name (DRIVE_NOT_REACHED)? We don't want
> to (and don't indeed) warn user when it is in the real 'offline' status with
> disconnected
> network. I think we should be better to tell that authentication is failed
here,
> not just
> 'unreachable'.

Thanks for comment. I updated the description.

As for the warning message, I think this is enough. It contains current status
(unreachable) and what to do next (logout). But rather,   saying 'authentication
failed' may cause misleads. (and the issue is better to discuss about strings,
because the current one is by josh and josh may have some idea.)

I also think we should have another message or icon when offline-mode due to
network problem. Filed http://crbug.com/174874

[kinaba, 2013-02-08 01:00:41]

On 2013/02/07 10:31:16, yoshiki wrote:
> On 2013/02/07 04:30:26, kinaba wrote:
> > On 2013/02/07 00:15:08, yoshiki wrote:
> > > @kinaba, could you take a look? thanks,
> > 
> > code change looks good,  but could you be more explicit in the patch
> > description,
> > message text, and the message text ID name (DRIVE_NOT_REACHED)? We don't
want
> > to (and don't indeed) warn user when it is in the real 'offline' status with
> > disconnected
> > network. I think we should be better to tell that authentication is failed
> here,
> > not just
> > 'unreachable'.
> 
> Thanks for comment. I updated the description.
> 
> As for the warning message, I think this is enough. It contains current status
> (unreachable) and what to do next (logout). But rather,   saying
'authentication
> failed' may cause misleads. (and the issue is better to discuss about strings,
> because the current one is by josh and josh may have some idea.)
> 
> I also think we should have another message or icon when offline-mode due to
> network problem. Filed http://crbug.com/174874

OK, LGTM

[commit-bot: I haz the power, 2013-02-08 05:06:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12226034/4002

[commit-bot: I haz the power, 2013-02-08 05:06:14]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 472.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
6a53883e88bee4be4d0d6763c4fe978eff50a3f8..35e39df09250998897f190c768e92911a38891da
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -472,6 +472,7 @@ enum HistogramValue {
   NETWORKINGPRIVATE_STARTDISCONNECT,
   MEDIAGALLERIESPRIVATE_GETALLGALLERYWATCH,
   MEDIAGALLERIESPRIVATE_REMOVEALLGALLERYWATCH,
+  FILEBROWSERPRIVATE_LOGOUT,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-02-08 06:23:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12226034/10002

[commit-bot: I haz the power, 2013-02-08 06:23:29]

Presubmit check for 12226034-10002 failed and returned exit status 1.

INFO:root:Found 9 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/extensions/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/resources/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/common/extensions/api
    chrome/browser/chromeos/extensions
    chrome/browser/extensions

Presubmit checks took 6.1s to calculate.

[yoshiki, 2013-02-08 06:48:14]

Satoru-san, could you take a look at the extension part
(chrome/browser/chromeos/extensions/*)?

[satorux1, 2013-02-08 07:28:15]

The API name "logout" sounded a bit odd to me. Maybe "logoutUser" sounds better?
You need to get approval from extensions owners. adding asanka.

https://codereview.chromium.org/12226034/diff/8008/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_browser_private_api.h (right):

https://codereview.chromium.org/12226034/diff/8008/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_browser_private_api.h:68: class
LogoutFunction : public AsyncExtensionFunction {
LogoutUserFunction

https://codereview.chromium.org/12226034/diff/8008/chrome/common/extensions/a...
File chrome/common/extensions/api/file_browser_private.json (right):

https://codereview.chromium.org/12226034/diff/8008/chrome/common/extensions/a...
chrome/common/extensions/api/file_browser_private.json:386: "name": "logout",
logoutUser

https://codereview.chromium.org/12226034/diff/8008/chrome/common/extensions/a...
chrome/common/extensions/api/file_browser_private.json:388: "description":
"Logout user.",
Logs out the current user.

[satorux1, 2013-02-08 13:34:20]

oops. I meant to add asargent. sorry about the mess!

[asargent_no_longer_on_chrome, 2013-02-11 22:09:13]

I agree with satorux1's comments, but other than that things look fine. When
you've uploaded a new version addressing those comments, publish a comment on
the review saying so and I'll give it a final look.

[yoshiki, 2013-02-12 01:13:32]

@satorux1, @asargent: Thank for the comments, I've changed the API name to
"logoutUser". PTAL.

https://codereview.chromium.org/12226034/diff/8008/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_browser_private_api.h (right):

https://codereview.chromium.org/12226034/diff/8008/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_browser_private_api.h:68: class
LogoutFunction : public AsyncExtensionFunction {
On 2013/02/08 07:28:15, satorux1 wrote:
> LogoutUserFunction

Done.

https://codereview.chromium.org/12226034/diff/8008/chrome/common/extensions/a...
File chrome/common/extensions/api/file_browser_private.json (right):

https://codereview.chromium.org/12226034/diff/8008/chrome/common/extensions/a...
chrome/common/extensions/api/file_browser_private.json:386: "name": "logout",
On 2013/02/08 07:28:15, satorux1 wrote:
> logoutUser

Done.

https://codereview.chromium.org/12226034/diff/8008/chrome/common/extensions/a...
chrome/common/extensions/api/file_browser_private.json:388: "description":
"Logout user.",
On 2013/02/08 07:28:15, satorux1 wrote:
> Logs out the current user.

Done.

[satorux1, 2013-02-14 04:38:33]

The new API name LGTM.

[yoshiki, 2013-02-14 06:21:19]

@asargent: PTAL

[asargent_no_longer_on_chrome, 2013-02-14 18:49:30]

LGTM w/ 1 nit

https://codereview.chromium.org/12226034/diff/3002/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

https://codereview.chromium.org/12226034/diff/3002/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:683:
SendResponse(true);
nit: since you just do the work and send the response immediately, you don't
need this function to inherit from AsyncExtensionFunction (that's only for
functions which need to do some more work, e.g. on another thread, before being
ready to have the function return). 

Instead, you can just inherit from SyncExtensionFunction, and then you just
return true and don't need to manually call SendResponse here.

[commit-bot: I haz the power, 2013-02-18 02:14:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12226034/9005

[commit-bot: I haz the power, 2013-02-18 03:41:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-18 04:25:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12226034/34002

[commit-bot: I haz the power, 2013-02-18 06:34:28]

Change committed as 183071