Rename "unload" to "suspend" for consistency

Rename "unload" to "suspend" for consistency

Rename all constants, methods, etc. related to the "chrome.runtime.onSuspend" event
to use the work "Suspend" instead of "Reload". Reload means a different thing in the
rest of the codebase (it means "disabled" or about to be reloaded fresh from disk).

BUG=
[email protected] (for mechanical changes in chrome/.)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182945

[rpaquay, 2013-02-15 19:23:28]

Matt,

This refactoring is (somewhat) related to issue 165273. It seems we have a
terminology issue in the code base - we have 2 meanings for "unload":
1) "unload" of an event page due to a "onSuspend" event
2) "unload" of an extension due to a "disabled/uninstall" event (e.g.
NOTIFICATION_EXTENSION_UNLOADED).

This CL is about renaming all definitions related to 1) to contain the word
"suspend" instead of "unload". "suspend" is the concept we expose in the public
API ("chrome.runtime.OnSuspend" event).

What do you think?

[Matt Perry, 2013-02-15 19:26:06]

Good call, I agree. LGTM

[miket_OOO, 2013-02-15 19:30:10]

Cool.

[commit-bot: I haz the power, 2013-02-15 19:32:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12283009/1

[commit-bot: I haz the power, 2013-02-15 19:32:47]

Presubmit check for 12283009-1 failed and returned exit status 1.

INFO:root:Found 13 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/extensions/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/common/extensions/extension_messages.h

Presubmit checks took 2.1s to calculate.

[rpaquay, 2013-02-15 20:24:22]

Add cevans@ for review on chrome/common/extensions/extension_messages.h (trivial
change)

[Chris Evans, 2013-02-15 20:49:36]

On 2013/02/15 20:24:22, rpaquay wrote:
> Add cevans@ for review on chrome/common/extensions/extension_messages.h
(trivial
> change)

LGTM

[commit-bot: I haz the power, 2013-02-15 21:41:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12283009/1

[commit-bot: I haz the power, 2013-02-15 21:41:24]

Presubmit check for 12283009-1 failed and returned exit status 1.

INFO:root:Found 13 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/extensions/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 2.9s to calculate.

[commit-bot: I haz the power, 2013-02-15 21:51:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12283009/1

[commit-bot: I haz the power, 2013-02-15 22:29:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12283009/1

[commit-bot: I haz the power, 2013-02-16 07:02:36]

Change committed as 182945