Issue 12316162: Show the IME if needed on accessibility gestures

Issue 12316162: Show the IME if needed on accessibility gestures (Closed)

Created:
7 years, 9 months ago by David Trainor- moved to gerrit

Modified:
7 years, 9 months ago

Reviewers:
Ted C, palmer, aurimas (slooooooooow), Yaron, jamesr

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Show the IME if needed on accessibility gestures When the user performs an accessibilty gesture on Android, we don't show the IME if a text input box was focused. This is basically a user action and we should show the IME in this case. BUG=179093 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185368

Patch Set 1 #

Patch Set 2 : Added unit test #

Patch Set 3 : Base files missing? #

Patch Set 4 : Accidentially left in method. Removed it. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -2 lines)			Patch
M	content/browser/android/content_view_core_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	content/public/android/javatests/src/org/chromium/content/browser/ImeTest.java	View	1 2 3	2 chunks	+26 lines, -0 lines	0 comments	Download
M	content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	content/renderer/render_widget.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	1	3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

David Trainor- moved to gerrit

PTAL. Aurimas: General flow Ted: Android specific (contentviewcore / accessibilityinjector) Palmer: view_messages James: render_widget Thanks!

7 years, 9 months ago (2013-02-27 20:02:20 UTC) #1

David Trainor- moved to gerrit

Added tests as per Aurimas' request. Aurimas/Ted PTAL at Java tests/DOMUtils changes. Thanks!

7 years, 9 months ago (2013-02-28 00:28:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12316162/9003

7 years, 9 months ago (2013-02-28 17:57:05 UTC) #7

commit-bot: I haz the power

Presubmit check for 12316162-9003 failed and returned exit status 1. INFO:root:Found 9 file(s). Running presubmit ...

7 years, 9 months ago (2013-02-28 17:57:12 UTC) #8

David Trainor- moved to gerrit

Yaron can I get an LGTM on DOMUtils.java?

7 years, 9 months ago (2013-02-28 18:05:45 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12316162/13002

7 years, 9 months ago (2013-02-28 19:20:12 UTC) #11

Message was sent while issue was closed.

Change committed as 185368

Expand Messages | Collapse Messages