Issue 12317012: Disk cache: use mmap for cache index on x86.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12317012: Disk cache: use mmap for cache index on x86. (Closed)

Created:
7 years, 10 months ago by pasko-google - do not use

Modified:
7 years, 10 months ago

Reviewers:
willchan no longer on Chromium, kerz_chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Disk cache: use mmap for cache index on x86. We are pretty confident that mmap-ing the index would not hurt any existing x86 android devices, but we cannot be so sure about the variety of ARM devices. So enable it for x86 only for now. BUG=170344 TEST=instrument mapped_file_avoid_mmap_posix.cc:Flush() and make sure it is not invoked when run on an x86 device Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183610

Patch Set 1 #

Patch Set 2 : added patch description into the comment" #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	net/net.gyp	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

Can you update the comments in net.gyp with the explanation you've put into the changelist ...

7 years, 10 months ago (2013-02-20 17:26:58 UTC) #2

pasko-google - do not use

On 2013/02/20 17:26:58, willchan wrote: > Can you update the comments in net.gyp with the ...

7 years, 10 months ago (2013-02-20 17:51:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12317012/10001

7 years, 10 months ago (2013-02-20 17:52:50 UTC) #4

Message was sent while issue was closed.

Change committed as 183610

Expand Messages | Collapse Messages