Add a flag to disable gesture requirement for media playback

Add a flag to disable gesture requirement for media playback

For webGL, we need to enable video autoplay in some circumstances. Adding a flag so that developers to test their page.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185720

[qinmin, 2013-03-01 19:33:27]

PTAL

[Ken Russell (switch to Gerrit), 2013-03-01 20:26:00]

Thanks, LGTM. For other reviewers, this flag is needed in order to pass the
WebGL conformance tests on Android.

[sky, 2013-03-01 20:31:48]

LGTM

[jam, 2013-03-01 22:53:23]

lgtm

[commit-bot: I haz the power, 2013-03-01 23:03:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12378045/1

[commit-bot: I haz the power, 2013-03-01 23:03:59]

Failed to apply patch for content/browser/web_contents/web_contents_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/web_contents/web_contents_impl.cc
  Hunk #1 FAILED at 537.
  1 out of 1 hunk FAILED -- saving rejects to file
content/browser/web_contents/web_contents_impl.cc.rej

Patch:       content/browser/web_contents/web_contents_impl.cc
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc
b/content/browser/web_contents/web_contents_impl.cc
index
e8e55a7428126417ecbbf40ac46133eb9818df5c..de48b185961dba7a7634f1fdaf41fd03dd6eb5eb
100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -537,6 +537,10 @@ WebPreferences
WebContentsImpl::GetWebkitPrefs(RenderViewHost* rvh,
       command_line.HasSwitch(switches::kEnableGpuBenchmarking);
   prefs.threaded_html_parser =
       command_line.HasSwitch(switches::kEnableThreadedHTMLParser);
+#if defined(OS_ANDROID)
+  prefs.user_gesture_required_for_media_playback = !command_line.HasSwitch(
+      switches::kDisableGestureRequirementForMediaPlayback);
+#endif
 
   bool touch_device_present = false;
   touch_device_present = ui::IsTouchDevicePresent();

[commit-bot: I haz the power, 2013-03-01 23:36:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12378045/6001

[commit-bot: I haz the power, 2013-03-02 16:16:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12378045/6001

[commit-bot: I haz the power, 2013-03-02 17:26:10]

Change committed as 185720