Expose a concept of bottom overdraw amount for cc drawing viewport.

Expose a concept of bottom overdraw amount for cc drawing viewport.

When the physical output surface is larger than the visible viewport,
we need to subtract the overdraw to ensure you can scroll to the
full content of the page.

Resizing the output surface is expensive on mobile devices, so we
minimize resizes and deal with this size mismatch.

BUG=161303, 221995
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190142

[Ted C, 2013-03-20 02:21:44]

@aelias - PTAL

First pass before I open this up to the larger masses

[aelias_OOO_until_Jul13, 2013-03-20 03:07:02]

Looks generally fine.

https://codereview.chromium.org/12437023/diff/1/cc/trees/layer_tree_host.cc
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/12437023/diff/1/cc/trees/layer_tree_host.cc#n...
cc/trees/layer_tree_host.cc:583: SetPinchZoomScrollbarsBoundsAndPosition();
We actually don't use "PinchZoomScrollbars", that's ChromeOS only.  You can
remove this line.

https://codereview.chromium.org/12437023/diff/1/content/renderer/render_widget.h
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/12437023/diff/1/content/renderer/render_widge...
content/renderer/render_widget.h:526: // The amount the physical backing size
overdraws off the bottom of the
For more clarity, how about: "The area of the physical backing overdrawn
opaquely in the browser, for example by an on-screen-keyboard (in DPI-adjusted
pixels)."

[Ted C, 2013-03-20 17:17:55]

+jamesr - PTAL

https://codereview.chromium.org/12437023/diff/1/cc/trees/layer_tree_host.cc
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/12437023/diff/1/cc/trees/layer_tree_host.cc#n...
cc/trees/layer_tree_host.cc:583: SetPinchZoomScrollbarsBoundsAndPosition();
On 2013/03/20 03:07:07, aelias wrote:
> We actually don't use "PinchZoomScrollbars", that's ChromeOS only.  You can
> remove this line.

Done.

https://codereview.chromium.org/12437023/diff/1/content/renderer/render_widget.h
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/12437023/diff/1/content/renderer/render_widge...
content/renderer/render_widget.h:526: // The amount the physical backing size
overdraws off the bottom of the
On 2013/03/20 03:07:07, aelias wrote:
> For more clarity, how about: "The area of the physical backing overdrawn
> opaquely in the browser, for example by an on-screen-keyboard (in DPI-adjusted
> pixels)."

Done.

[jamesr, 2013-03-21 23:39:11]

lgtm (my OWNERS will only work for content/renderer/, though)

[Ted C, 2013-03-22 00:53:37]

+sky - content/browser
+joi - content/port
+palmer - content/common -- IPC change

[palmer, 2013-03-22 01:32:20]

IPC security LGTM

[Jói, 2013-03-22 07:52:09]

LGTM for content/port. Please add jam+ as FYI once you have all content LGTMs.

On Fri, Mar 22, 2013 at 1:32 AM,  <[email protected]> wrote:
> IPC security LGTM
>
> https://codereview.chromium.org/12437023/

[sky, 2013-03-22 18:13:57]

sky->pimany

[piman, 2013-03-22 20:10:11]

lgtm

[Ted C, 2013-03-22 20:21:03]

+jam - FYI for content changes

[commit-bot: I haz the power, 2013-03-22 20:34:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12437023/5001

[commit-bot: I haz the power, 2013-03-23 00:05:15]

Failed to trigger a try job on win_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-03-23 00:05:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12437023/36002

[commit-bot: I haz the power, 2013-03-23 14:50:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12437023/36002

[commit-bot: I haz the power, 2013-03-23 21:29:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12437023/66001

[commit-bot: I haz the power, 2013-03-23 21:55:55]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-23 22:12:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12437023/67030

[commit-bot: I haz the power, 2013-03-24 01:36:44]

Change committed as 190142