Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 12449003: Add support for synchronously resizing a render view for layout tests. (Closed)

Created:
7 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Add support for synchronously resizing a render view for layout tests. BUG=111316 [email protected] TEST=fast/dom/Window/window-resize-contents.html and fast/autoresize/turn-off-autoresize.html passes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186308

Patch Set 1 #

Total comments: 3

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -18 lines) Patch
M content/public/test/layouttest_support.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +11 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +18 lines, -3 lines 0 comments Download
M content/shell/shell_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/shell_render_process_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/webkit_test_controller.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/webkit_test_controller.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/shell/webkit_test_runner.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
7 years, 9 months ago (2013-03-05 13:54:44 UTC) #1
piman
I'm not entirely convinced I understand all the interactions between all the states involved. Some ...
7 years, 9 months ago (2013-03-05 19:40:11 UTC) #2
jochen (gone - plz use gerrit)
all done! I verified locally that the layout tests still pass.
7 years, 9 months ago (2013-03-05 20:44:11 UTC) #3
piman
OK, LGTM. I guess it doesn't modify the flow except for the tests that enable ...
7 years, 9 months ago (2013-03-05 20:56:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12449003/6001
7 years, 9 months ago (2013-03-05 21:07:27 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-05 21:14:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12449003/6001
7 years, 9 months ago (2013-03-05 21:49:46 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-06 00:55:04 UTC) #8
Message was sent while issue was closed.
Change committed as 186308

Powered by Google App Engine
This is Rietveld 408576698