Allow bubble scrolling that will result in the top controls becoming visible.

Allow bubble scrolling that will result in the top controls becoming visible.

Helps on sites that enter fullscreen and have a large scrolling div
that makes it difficult to find the root layer to scroll on.

BUG=172638
R=aelias


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190059

[Ted C, 2013-03-21 18:36:29]

aelias - PTAL

[aelias_OOO_until_Jul13, 2013-03-21 19:11:54]

https://codereview.chromium.org/12527013/diff/1/cc/trees/layer_tree_host_impl.cc
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/12527013/diff/1/cc/trees/layer_tree_host_impl...
cc/trees/layer_tree_host_impl.cc:1511: if (top_controls_manager_ &&
!pinch_gesture_active()
Why !pinch_gesture_active()?  If a pinch gesture is active, that implies the
CurrentlyScrollingLayer is the RootScrollLayer anyway.

https://codereview.chromium.org/12527013/diff/1/cc/trees/layer_tree_host_impl...
cc/trees/layer_tree_host_impl.cc:1513: && (CurrentlyScrollingLayer() ==
RootScrollLayer()
Can you put most of these conditions in a bool above the for loop:

bool consume_by_top_controls = top_controls_manager_ &&
(CurrentlyScrollingLayer() == RootScrollLayer() || scroll_delta.y() < 0);

[Ted C, 2013-03-21 19:43:42]

https://codereview.chromium.org/12527013/diff/1/cc/trees/layer_tree_host_impl.cc
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/12527013/diff/1/cc/trees/layer_tree_host_impl...
cc/trees/layer_tree_host_impl.cc:1511: if (top_controls_manager_ &&
!pinch_gesture_active()
On 2013/03/21 19:11:55, aelias wrote:
> Why !pinch_gesture_active()?  If a pinch gesture is active, that implies the
> CurrentlyScrollingLayer is the RootScrollLayer anyway.

Ah that was a mistake.  I was testing something else and forgot about it. 
Removed.

https://codereview.chromium.org/12527013/diff/1/cc/trees/layer_tree_host_impl...
cc/trees/layer_tree_host_impl.cc:1513: && (CurrentlyScrollingLayer() ==
RootScrollLayer()
On 2013/03/21 19:11:55, aelias wrote:
> Can you put most of these conditions in a bool above the for loop:
> 
> bool consume_by_top_controls = top_controls_manager_ &&
> (CurrentlyScrollingLayer() == RootScrollLayer() || scroll_delta.y() < 0);

Done.

[aelias_OOO_until_Jul13, 2013-03-21 20:24:56]

lgtm

[commit-bot: I haz the power, 2013-03-22 00:43:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12527013/5001

[commit-bot: I haz the power, 2013-03-22 18:20:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12527013/5001

[commit-bot: I haz the power, 2013-03-22 18:20:30]

Failed to trigger a try job on win_x64_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-03-22 19:45:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12527013/21002

[commit-bot: I haz the power, 2013-03-23 01:31:36]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-03-23 17:07:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12527013/21002

[commit-bot: I haz the power, 2013-03-23 18:49:47]

Change committed as 190059