Removed data reduction experiment in about:flags for stable Channel

Removed data reduction experiment in about:flags for stable Channel

This change must be reverted to make the data reduction
feature available on stable.

BUG=222514
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190104

[Lei Zhang, 2013-03-22 19:25:46]

Which version are you trying to disable it for? M27+? M26+?

[bengr, 2013-03-22 19:29:07]

On 2013/03/22 19:25:46, Lei Zhang wrote:
> Which version are you trying to disable it for? M27+? M26+?

M26+

[Lei Zhang, 2013-03-22 19:54:04]

This works, of course, but I'm trying to figure out why you're the only one
doing this here. Surely someone else must have wanted to do this before. I'm
wondering if there's a different way.

https://codereview.chromium.org/12634031/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12634031/diff/1/chrome/browser/about_flags.cc...
chrome/browser/about_flags.cc:1476: // Special case enable-spdy-proxy-auth,
because it should only
Put this inside #if defined(OS_ANDROID) ?

[bengr, 2013-03-22 20:12:50]

https://codereview.chromium.org/12634031/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12634031/diff/1/chrome/browser/about_flags.cc...
chrome/browser/about_flags.cc:1476: // Special case enable-spdy-proxy-auth,
because it should only
On 2013/03/22 19:54:04, Lei Zhang wrote:
> Put this inside #if defined(OS_ANDROID) ?

Done.

[bengr, 2013-03-22 20:16:31]

I suspect that special casing CHANNEL_STABLE is rather unusual for experiments;
otherwise the Experiment struct would hold a field for supported channels.

On 2013/03/22 19:54:04, Lei Zhang wrote:
> This works, of course, but I'm trying to figure out why you're the only one
> doing this here. Surely someone else must have wanted to do this before. I'm
> wondering if there's a different way.
> 
> https://codereview.chromium.org/12634031/diff/1/chrome/browser/about_flags.cc
> File chrome/browser/about_flags.cc (right):
> 
>
https://codereview.chromium.org/12634031/diff/1/chrome/browser/about_flags.cc...
> chrome/browser/about_flags.cc:1476: // Special case enable-spdy-proxy-auth,
> because it should only
> Put this inside #if defined(OS_ANDROID) ?

[Lei Zhang, 2013-03-23 01:26:01]

LGTM on the condition that we'll revert this after:
- Merging this to M26.
- The M27 branch takes place.

[commit-bot: I haz the power, 2013-03-23 12:49:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12634031/1002

[commit-bot: I haz the power, 2013-03-23 15:12:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12634031/1002

[commit-bot: I haz the power, 2013-03-23 23:08:45]

Change committed as 190104