Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Issue 12637006: Reland r187230: Implement the Stream registry in content (Closed)

Created:
7 years, 9 months ago by Zachary Kuznia
Modified:
7 years, 9 months ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, joi+watch-content_chromium.org, jam, rdsmith+dwatch_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Reland r187230: Implement the Stream registry in content This fixes the memory leaks introduced by the original CL. BUG=171585 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187777

Patch Set 1 #

Patch Set 2 : Remove extra code #

Patch Set 3 : Use weak pointers #

Patch Set 4 : Add comment #

Patch Set 5 : Add another comment #

Patch Set 6 : Fix the comment #

Patch Set 7 : Initialize a missing variable #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+718 lines, -0 lines) Patch
M content/browser/download/byte_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/resource_context_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/resource_context_impl.cc View 4 chunks +14 lines, -0 lines 0 comments Download
A content/browser/streams/stream.h View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A content/browser/streams/stream.cc View 1 2 1 chunk +116 lines, -0 lines 0 comments Download
A content/browser/streams/stream_context.h View 1 chunk +60 lines, -0 lines 0 comments Download
A content/browser/streams/stream_context.cc View 1 2 3 4 5 1 chunk +57 lines, -0 lines 0 comments Download
A content/browser/streams/stream_read_observer.h View 1 chunk +24 lines, -0 lines 0 comments Download
A content/browser/streams/stream_registry.h View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A content/browser/streams/stream_registry.cc View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A content/browser/streams/stream_unittest.cc View 1 2 3 4 5 6 1 chunk +207 lines, -0 lines 0 comments Download
A content/browser/streams/stream_write_observer.h View 1 chunk +24 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Zachary Kuznia
I reverted the last patch, since it caused HeapCheck and Valgrind errors. This patch resolves ...
7 years, 9 months ago (2013-03-11 12:41:14 UTC) #1
Zachary Kuznia
FYI, the changes I needed to make are just using weak pointers for connecting to ...
7 years, 9 months ago (2013-03-11 15:43:25 UTC) #2
kinuko
The diff lgtm
7 years, 9 months ago (2013-03-12 03:39:14 UTC) #3
darin (slow to review)
LGTM2
7 years, 9 months ago (2013-03-12 04:08:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12637006/51001
7 years, 9 months ago (2013-03-12 23:44:58 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-13 04:34:21 UTC) #6
Message was sent while issue was closed.
Change committed as 187777

Powered by Google App Engine
This is Rietveld 408576698