Create separate sections for available/unavailable flags.

Create separate sections for available/unavailable flags. 

On Linux, searching for "this experiment is not supported" returns 23 
results. To make it a little easier to navigate, create a separate
section to list all the unsupported experiments.

BUG=179649
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201015

[dcheng, 2013-04-04 00:52:04]

While you're at it, mind taking an initial look at this?

I need to figure out how to get sign off on the UI changes though.

[Dan Beam, 2013-04-04 01:03:37]

jstemplate turns on my rage oven

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/abou...
File chrome/browser/about_flags.cc (right):

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/abou...
chrome/browser/about_flags.cc:1575: if (supported)
nit: I'd just inline

  if (experiment.supported_platforms & current_platform)

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/reso...
File chrome/browser/resources/flags.html (right):

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/reso...
chrome/browser/resources/flags.html:31: <div>
^ what's the point of this?  also, indent more if it stays

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/reso...
chrome/browser/resources/flags.html:49: jsdisplay="supportedExperiments.length
=== 0">
you could probably just put == here

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/reso...
chrome/browser/resources/flags.html:108: <div id="top" class="wbox">
indent each nested level

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/reso...
chrome/browser/resources/flags.html:129: <table width="100%" cellpadding="2"
cellspacing="0">
^ why are you using a table?

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/reso...
chrome/browser/resources/flags.html:155: <button
class="experiment-restart-button"
type=button could probably fit up a line

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/webui/flags_ui.cc (right):

https://chromiumcodereview.appspot.com/12748002/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/flags_ui.cc:137: ListValue* unsupported_experiments =
new ListValue;
nit: scoped_ptr<ListValue> supported... .Set(supported.release())

[dcheng, 2013-04-23 00:17:01]

Sorry for the long turnaround. I got caught up in a lot of other things.

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/about_flags...
chrome/browser/about_flags.cc:1575: if (supported)
On 2013/04/04 01:03:37, Dan Beam wrote:
> nit: I'd just inline
> 
>   if (experiment.supported_platforms & current_platform)

I did this originally... but have reverted it since due to the CrOS owner
changes on lines 1620-1626.

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/flags.html (right):

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/flags.html:31: <div>
On 2013/04/04 01:03:37, Dan Beam wrote:
> ^ what's the point of this?  also, indent more if it stays

Done. I think this got introduced during some CSS shenanigans.

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/flags.html:49: jsdisplay="supportedExperiments.length
=== 0">
On 2013/04/04 01:03:37, Dan Beam wrote:
> you could probably just put == here

Done.

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/flags.html:108: <div id="top" class="wbox">
On 2013/04/04 01:03:37, Dan Beam wrote:
> indent each nested level

This is (unfortunately) largely duplicated from the previous section for
supported flags. There's already a lot of places where nested elements aren't
properly indented; is this something you'd like me to fix in this patch?

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/flags.html:129: <table width="100%" cellpadding="2"
cellspacing="0">
On 2013/04/04 01:03:37, Dan Beam wrote:
> ^ why are you using a table?

Because that's what the supported experiments section uses.

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/flags.html:155: <button
class="experiment-restart-button"
On 2013/04/04 01:03:37, Dan Beam wrote:
> type=button could probably fit up a line

Done.

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/ui/webui/fl...
File chrome/browser/ui/webui/flags_ui.cc (right):

https://codereview.chromium.org/12748002/diff/2001/chrome/browser/ui/webui/fl...
chrome/browser/ui/webui/flags_ui.cc:137: ListValue* unsupported_experiments =
new ListValue;
On 2013/04/04 01:03:37, Dan Beam wrote:
> nit: scoped_ptr<ListValue> supported... .Set(supported.release())

Done.

[dcheng, 2013-04-29 21:46:11]

ping

[Dan Beam, 2013-04-29 21:55:48]

generally lg, do you have screenshots?

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
chrome/browser/about_flags.cc:1639: bool supported =
(experiment.supported_platforms & current_platform) != 0;
nit: just use & instead of ( & ) != 0, IMO

  bool supported = experiment.supported_platforms & current_platform;

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
chrome/browser/about_flags.cc:1642: (experiment.supported_platforms &
kOsCrOSOwnerOnly) != 0)
nit: curlies

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
File chrome/browser/about_flags_unittest.cc (right):

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
chrome/browser/about_flags_unittest.cc:269: // Experiment 3 should show still be
persisted in preferences though.
fix comment

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/resources/...
File chrome/browser/resources/flags.html (right):

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/resources/...
chrome/browser/resources/flags.html:113: <span class="section-header-title"
i18n-content="flagsUnsupportedTableTitle"
<span class="section-header-title"
      i18n-content="flagsUnsupportedTableTitle"
  >TITLE
</span>

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/resources/...
chrome/browser/resources/flags.html:139: <span
jsvalues=".innerHTML:description">
</span>

[dcheng, 2013-05-10 19:52:41]

I've updated this patch... but given Mike's recent changes (see
http://crrev.com/198875), I'm not really sure we need/want this anymore.

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
chrome/browser/about_flags.cc:1639: bool supported =
(experiment.supported_platforms & current_platform) != 0;
On 2013/04/29 21:55:48, Dan Beam wrote:
> nit: just use & instead of ( & ) != 0, IMO
> 
>   bool supported = experiment.supported_platforms & current_platform;

Done.

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
chrome/browser/about_flags.cc:1642: (experiment.supported_platforms &
kOsCrOSOwnerOnly) != 0)
On 2013/04/29 21:55:48, Dan Beam wrote:
> nit: curlies

Done.

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
File chrome/browser/about_flags_unittest.cc (right):

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
chrome/browser/about_flags_unittest.cc:269: // Experiment 3 should show still be
persisted in preferences though.
On 2013/04/29 21:55:48, Dan Beam wrote:
> fix comment

I think this comment is still accurate. We are reading the pref directly.

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/resources/...
File chrome/browser/resources/flags.html (right):

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/resources/...
chrome/browser/resources/flags.html:113: <span class="section-header-title"
i18n-content="flagsUnsupportedTableTitle"
On 2013/04/29 21:55:48, Dan Beam wrote:
> <span class="section-header-title"
>       i18n-content="flagsUnsupportedTableTitle"
>   >TITLE
> </span>

Done.

https://codereview.chromium.org/12748002/diff/29002/chrome/browser/resources/...
chrome/browser/resources/flags.html:139: <span
jsvalues=".innerHTML:description">
On 2013/04/29 21:55:48, Dan Beam wrote:
> </span>

Done, and fixed the missing </span> at line 69 as well.

[dcheng, 2013-05-10 21:23:38]

On 2013/05/10 19:52:41, dcheng wrote:
> I've updated this patch... but given Mike's recent changes (see
> http://crrev.com/198875), I'm not really sure we need/want this anymore.
> 
>
https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
> File chrome/browser/about_flags.cc (right):
> 
>
https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
> chrome/browser/about_flags.cc:1639: bool supported =
> (experiment.supported_platforms & current_platform) != 0;
> On 2013/04/29 21:55:48, Dan Beam wrote:
> > nit: just use & instead of ( & ) != 0, IMO
> > 
> >   bool supported = experiment.supported_platforms & current_platform;
> 
> Done.
> 
>
https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
> chrome/browser/about_flags.cc:1642: (experiment.supported_platforms &
> kOsCrOSOwnerOnly) != 0)
> On 2013/04/29 21:55:48, Dan Beam wrote:
> > nit: curlies
> 
> Done.
> 
>
https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
> File chrome/browser/about_flags_unittest.cc (right):
> 
>
https://codereview.chromium.org/12748002/diff/29002/chrome/browser/about_flag...
> chrome/browser/about_flags_unittest.cc:269: // Experiment 3 should show still
be
> persisted in preferences though.
> On 2013/04/29 21:55:48, Dan Beam wrote:
> > fix comment
> 
> I think this comment is still accurate. We are reading the pref directly.
> 
>
https://codereview.chromium.org/12748002/diff/29002/chrome/browser/resources/...
> File chrome/browser/resources/flags.html (right):
> 
>
https://codereview.chromium.org/12748002/diff/29002/chrome/browser/resources/...
> chrome/browser/resources/flags.html:113: <span class="section-header-title"
> i18n-content="flagsUnsupportedTableTitle"
> On 2013/04/29 21:55:48, Dan Beam wrote:
> > <span class="section-header-title"
> >       i18n-content="flagsUnsupportedTableTitle"
> >   >TITLE
> > </span>
> 
> Done.
> 
>
https://codereview.chromium.org/12748002/diff/29002/chrome/browser/resources/...
> chrome/browser/resources/flags.html:139: <span
> jsvalues=".innerHTML:description">
> On 2013/04/29 21:55:48, Dan Beam wrote:
> > </span>
> 
> Done, and fixed the missing </span> at line 69 as well.

I've posted some screenshots @ http://imgur.com/a/oT2kr as well.

[Mike West, 2013-05-14 12:26:03]

On 2013/05/10 19:52:41, dcheng wrote:
> I've updated this patch... but given Mike's recent changes (see
> http://crrev.com/198875), I'm not really sure we need/want this anymore.

FWIW, I think this is still a change worth making. My change makes it simpler to
link to specific flags. Your change makes it easier to parse the flags I have
available to me. Two different problems entirely. :)

[Dan Beam, 2013-05-17 02:30:19]

lgtm

btw, I think it'd be awesome if there was a search box on the top of about flags
that searches/filters flags as you type (like search in settings).  that'd be
boss.

https://codereview.chromium.org/12748002/diff/42003/chrome/browser/about_flag...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12748002/diff/42003/chrome/browser/about_flag...
chrome/browser/about_flags.cc:1722: (experiment.supported_platforms &
kOsCrOSOwnerOnly) != 0) {
experiment.supported_platforms & kOsCrOSOwnerOnly) {

[dcheng, 2013-05-17 02:57:47]

+thakis for OWNERS review for chrome/browser/about_flags* changes.

https://codereview.chromium.org/12748002/diff/42003/chrome/browser/about_flag...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12748002/diff/42003/chrome/browser/about_flag...
chrome/browser/about_flags.cc:1722: (experiment.supported_platforms &
kOsCrOSOwnerOnly) != 0) {
On 2013/05/17 02:30:19, Dan Beam wrote:
> experiment.supported_platforms & kOsCrOSOwnerOnly) {

Done.

[Nico, 2013-05-17 16:49:24]

*sigh* The bug sounds like you talked to UI peeps, so I'm just gonna say lgtm to
the code changes in about_flags and not say anything else :-P

[commit-bot: I haz the power, 2013-05-17 17:59:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12748002/51001

[commit-bot: I haz the power, 2013-05-17 18:44:46]

Retried try job too often on linux_aura for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-05-18 00:39:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12748002/68001

[dcheng, 2013-05-18 01:46:05]

https://codereview.chromium.org/12748002/diff/42003/chrome/browser/about_flag...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12748002/diff/42003/chrome/browser/about_flag...
chrome/browser/about_flags.cc:1722: (experiment.supported_platforms &
kOsCrOSOwnerOnly) != 0) {
On 2013/05/17 02:30:19, Dan Beam wrote:
> experiment.supported_platforms & kOsCrOSOwnerOnly) {

Actually, this doesn't compile on Windows. I've reverted it back to != 0.

[commit-bot: I haz the power, 2013-05-18 01:47:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12748002/83001

[commit-bot: I haz the power, 2013-05-18 03:43:39]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-18 07:25:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12748002/93001

[commit-bot: I haz the power, 2013-05-20 04:10:54]

Change committed as 201015