Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12855002: display GDI/USER handles in task manager on windows (Closed)

Created:
7 years, 9 months ago by scottmg
Modified:
7 years, 9 months ago
CC:
chromium-reviews, tfarina, erikwright+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

display GDI/USER handles in task manager on windows BUG=134837, 190221 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188838

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : move gdi/user getting into c/b/task_manager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 3 4 6 chunks +87 lines, -1 line 0 comments Download
A chrome/browser/task_manager/task_manager_os_resources_win.h View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/browser/task_manager/task_manager_os_resources_win.cc View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
brettw: base/ yoshiki: chrome/browser/task_manager/ ben: chrome/browser/ui/views/
7 years, 9 months ago (2013-03-14 00:39:08 UTC) #1
Ben Goodger (Google)
ui stuff lgtm
7 years, 9 months ago (2013-03-14 00:41:08 UTC) #2
brettw
Since this is only used in one place, it should not be in base. The ...
7 years, 9 months ago (2013-03-14 04:28:44 UTC) #3
scottmg
moved handle getting into c/b/task_manager. yoshiki, ptal. [-brettw]
7 years, 9 months ago (2013-03-14 18:59:28 UTC) #4
yoshiki
lgtm for task_manager
7 years, 9 months ago (2013-03-18 15:42:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12855002/12001
7 years, 9 months ago (2013-03-18 16:37:12 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-18 21:48:36 UTC) #7
Message was sent while issue was closed. 
Change committed as 188838

Powered by Google App Engine
This is Rietveld 408576698