Issue 13119005: DevTools: introduce Adb-based DevToolsExternalAgentProxyDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13119005: DevTools: introduce Adb-based DevToolsExternalAgentProxyDelegate. (Closed)

Created:
7 years, 9 months ago by pfeldman

Modified:
7 years, 9 months ago

Reviewers:
vsevik, Vladislav Kaznacheev

CC:
chromium-reviews, vsevik, yurys, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: introduce Adb-based DevToolsExternalAgentProxyDelegate. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190931

Patch Set 2 : Review comment addressed. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -14 lines)			Patch
	M	chrome/browser/devtools/devtools_adb_bridge.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	chrome/browser/devtools/devtools_adb_bridge.cc	View	1	6 chunks	+209 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

LGTM with a nit https://chromiumcodereview.appspot.com/13119005/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc File chrome/browser/devtools/devtools_adb_bridge.cc (right): https://chromiumcodereview.appspot.com/13119005/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc#newcode290 chrome/browser/devtools/devtools_adb_bridge.cc:290: std::string encoded_frame = WebSocket::EncodeFrameHybi17(data, 42); ...

7 years, 9 months ago (2013-03-27 09:49:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13119005/7002

7 years, 9 months ago (2013-03-27 11:36:11 UTC) #3

Message was sent while issue was closed.

Change committed as 190931

Expand Messages | Collapse Messages

Issue 13119005: DevTools: introduce Adb-based DevToolsExternalAgentProxyDelegate. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review comment addressed. #

Messages