Issue 13212007: Introduce browser-agnostic web contents modal dialog positioning abstraction and implement for Views

Issue 13212007: Introduce browser-agnostic web contents modal dialog positioning abstraction and implement for Views (Closed)

Created:
7 years, 8 months ago by Mike Wittman

Modified:
7 years, 8 months ago

Reviewers:
Elliot Glaysher, sail, Ben Goodger (Google)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, sail+watch_chromium.org, Aaron Boodman, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, ilya sherman; dvh_chromium.org, msw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Introduce browser-agnostic web contents modal dialog positioning abstraction and implement for Views Support positioning of the web contents modal dialog on a host window, independent of the type of the host window. Also, support repositioning the window when the host window geometry changes. Implement the abstraction for the Views browser window and Views web contents modal dialog. The implementation moves the dialog to the top overlapping the browser chrome and is enabled behind the --enable-new-dialog-style flag. Before/after screenshots at https://code.google.com/p/chromium/issues/detail?id=157161#c46. Visual artifacts/incorrect layout within the client area are a result of the new style dialog being a work in progress and will be addressed separately. BUG=157161 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191735

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address review comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+300 lines, -77 lines)			Patch
M	chrome/browser/ui/browser.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View		1 chunk	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/browser_window.h	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.mm	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_dialog_views.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/collected_cookies_views.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views.cc	View	1	4 chunks	+74 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views_browsertest.cc	View		5 chunks	+15 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout.h	View		5 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout.cc	View	1	6 chunks	+55 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/login_prompt_views.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/ssl_client_certificate_selector.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/ui/web_contents_modal_dialog_host.h	View		1 chunk	+45 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/web_contents_modal_dialog_host.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/web_contents_modal_dialog_manager_delegate.h	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/web_contents_modal_dialog_manager_delegate.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/base/test_browser_window.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/base/test_browser_window.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Mike Wittman

PTAL Ben: all, except for chrome/browser/ui/{gtk,cocoa}/* Elliot: chrome/browser/ui/*, chrome/browser/ui/gtk/* Sailesh: chrome/browser/ui/*, chrome/browser/ui/cocoa/*

7 years, 8 months ago (2013-03-29 22:46:29 UTC) #1

Ben Goodger (Google)

lgtm https://codereview.chromium.org/13212007/diff/1/chrome/browser/ui/views/constrained_window_views.cc File chrome/browser/ui/views/constrained_window_views.cc (right): https://codereview.chromium.org/13212007/diff/1/chrome/browser/ui/views/constrained_window_views.cc#newcode99 chrome/browser/ui/views/constrained_window_views.cc:99: ~WebContentsModalDialogHostObserverViews() { virtual https://codereview.chromium.org/13212007/diff/1/chrome/browser/ui/views/frame/browser_view_layout.cc File chrome/browser/ui/views/frame/browser_view_layout.cc (right): https://codereview.chromium.org/13212007/diff/1/chrome/browser/ui/views/frame/browser_view_layout.cc#newcode75 ...

7 years, 8 months ago (2013-04-01 17:41:08 UTC) #5

Mike Wittman

https://codereview.chromium.org/13212007/diff/1/chrome/browser/ui/views/constrained_window_views.cc File chrome/browser/ui/views/constrained_window_views.cc (right): https://codereview.chromium.org/13212007/diff/1/chrome/browser/ui/views/constrained_window_views.cc#newcode99 chrome/browser/ui/views/constrained_window_views.cc:99: ~WebContentsModalDialogHostObserverViews() { On 2013/04/01 17:41:08, Ben Goodger (Google) wrote: ...

7 years, 8 months ago (2013-04-01 21:59:43 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13212007/12001

7 years, 8 months ago (2013-04-01 22:57:38 UTC) #7

Message was sent while issue was closed.

Change committed as 191735

Expand Messages | Collapse Messages