Land Recent QUIC Changes

Add support for P-256 key exchange in crypto handshake.

Merge internal change: 44173744

Add default return to avoid crashing when we get an unknown
error code from the peer. 

Merge internal change: 44160057

Fix incorrect DCHECK while serializing version negotiation
packet.

Merge internal change: 44156166

Reorder the addends in GetPacketHeaderSize to match the order
of the public header fields.

Merge internal change: 44153020

Changing retransmission and retransmittable data boolean flags
to enums.

Merge internal change: 44071662

Remove methods from QuicTime for converting to/from
microseconds and milliseconds since the epoch for QuicTime is
unspecified.  (It wraps TimeTicks in Chromium). 

Merge internal change: 44069965

Change InterArrival feedback message to traffic in delta since
the "start" of the connection instead of a delta since the epoch.

One step closer to being able to remove QuicTime::To/FromMicroseconds
since those methods don't "do the right thing".

Merge internal change: 44037996

Changing kForce into an enum.

Merge internal change: 44024887

Cleanups from landing P-256 key exchange in Chromium.

Merge internal change: 44023801

Fix for std::vector in QuicPacketPublicHeader's memory
corruption by memset.

Merge internal change: 44022862

Merging cleanup changes from chromium.

Merge internal change: 44009665

Plug in the new decrypter and encrypter after the new keys have
been derived.

This is a first cut, as some details on changing the encryption
keys still need to be worked out.  Our interim solution is
permissive trial decryption, which allows the peer to encrypt
with the wrong key, either using the new key too early or using
the null key for too long.  The latter will leak confidential
information, so we err on the side of using the new key too early.

WARNING: the interim solution protects against eavesdroppers, but
is vulberable to active attackers.

Merge internal change: 44006658

Start tracking server and client stream resets and export them
via varz.

Merge internal change: 43971847

Pull out RstStreamFrame error code from QuicErrorCode so that
they don't appear in the tracked ConnectionClose error map.

This will also help in tracking RstStream error codes separately.

Merge internal change: 43968620

Adding Client/Server logging to all LOGS/DLOGs Not bothering
with VLOGs/DVLOGS unless it's requested.

Merge internal change: 43948596

crypto: step 5. 

This change implements source-address tokens at the server and has the client 
echo them. Source address tokens are opaque (to the client) bytestrings that 
prove ownership of an IP address. In order to prevent amplification attacks, 
the server demands that the client have a valid source address token for the IP 
address that it's claiming to come from and that the token is reasonably 
recent. 

Since we already have it implemented, this code uses AES-GCM to encrypt and 
authenticate the tokens with a fixed, dummy secret (for now). In the future, 
the secret will be derived from the primary, private key in the same way that 
SessionTicket keys used to be. 

The QuicEncrypter/Decrypter code was written to be quite specific to the task 
of encrypting and decrypting packets and, as part of this, it exposed only 64 
bits of the AEAD nonce. 

Since all GFEs will share the same token secret, and they'll all create tokens 
with random nonces, that runs an unacceptably high risk of an attacker 
obtaining two tokens with the same nonce. 

Thus this change also reworks the QuicEncrypter/Decrypter so that the full 
nonce is exposed and thus we can use 96-bit nonces. That's still not completely 
wonderful but, at 10Mpps an attacker would still take a year to obtain a pair 
of nonces, so it's good enough for a while at least. 

Merge internal change: 43893806 

[email protected]


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191569

[ramant (doing other things), 2013-03-29 22:08:16]

The Final branch with all the LGTM changes. Please take a look.

thanks
raman

[Ryan Hamilton, 2013-03-29 22:10:27]

Please change the title to "Land Recent QUIC Changes", and strip all of the QUIC
- prefixes from the descriptions in the body.

Otherwise, lgtm.

[ramant (doing other things), 2013-03-29 22:13:54]

On 2013/03/29 22:10:27, Ryan Hamilton wrote:
> Please change the title to "Land Recent QUIC Changes", and strip all of the
QUIC
> - prefixes from the descriptions in the body.
> 
> Otherwise, lgtm.

Done. thanks very much for quick code reviews and all your help.

[commit-bot: I haz the power, 2013-03-29 22:15:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13282004/1

[commit-bot: I haz the power, 2013-03-29 22:15:23]

Presubmit check for 13282004-1 failed and returned exit status 1.

INFO:root:Found 71 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/crypto/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/net/PRESUBMIT.py

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email [email protected] if you have questions.
  net/quic/crypto/crypto_handshake.cc:870
    scoped_ptr<QuicServerConfigProtobuf> config(ConfigForTesting(

If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    crypto/hkdf.cc

Presubmit checks took 4.7s to calculate.

[ramant (doing other things), 2013-03-29 22:17:46]

Hi wtc@ or agl@,
  Could you approve crypto/ changes (porting agl's changes for hkdf.cc).

[wtc, 2013-03-29 23:44:38]

Patch set 1 LGTM. I only reviewed crypto/hkdf.cc.

[ramant (doing other things), 2013-03-30 00:16:57]

Hi Wan-Teh,
  Could you please take a look at patch set#1.

[ramant (doing other things), 2013-03-30 00:20:08]

On 2013/03/30 00:16:57, ramant wrote:
> Hi Wan-Teh,
>   Could you please take a look at patch set#1.

I meant to say Patch Set #2.

thanks
raman

[wtc, 2013-03-30 00:24:51]

The NSS files in patch set 2 LGTM.

[commit-bot: I haz the power, 2013-03-30 00:28:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13282004/7001

[commit-bot: I haz the power, 2013-03-30 00:45:08]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-30 17:32:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13282004/25001

[commit-bot: I haz the power, 2013-03-30 18:42:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13282004/45001

[rtenneti, 2013-03-30 18:45:47]

Did a gclient sync and merged alyssar's CL for quic_server. and also
used wtc's PK11_Decrypt and PK11_Encrypt changes.


On Sat, Mar 30, 2013 at 11:42 AM, <[email protected]> wrote:

> CQ is trying da patch. Follow status at
> https://chromium-status.**appspot.com/cq/rtenneti@**
>
chromium.org/13282004/45001<https://chromium-status.appspot.com/cq/[email protected]/13282004/45001>
>
>
>
https://chromiumcodereview.**appspot.com/13282004/<https://chromiumcodereview...
>

[commit-bot: I haz the power, 2013-03-30 19:00:24]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-30 20:57:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13282004/53006

[commit-bot: I haz the power, 2013-03-30 21:14:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13282004/53006

[commit-bot: I haz the power, 2013-03-31 02:49:14]

Change committed as 191569