Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 13389002: Removes theming from popup windows on Mac (Closed)

Created:
7 years, 8 months ago by pkotwicz
Modified:
7 years, 5 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, sail+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removes theming from popup windows on Mac. The mac behavior is inconsistent with the other Chrome platforms which do not theme popup windows BUG=176857 Test=Manual, see steps below 1) Run Chrome on Mac, install a theme 2) Go to http://www.popuptest.com/popuptest1.html, check that the resulting popups are unthemed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212217

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -29 lines) Patch
M chrome/browser/ui/cocoa/framed_browser_window.mm View 1 2 3 4 5 2 chunks +13 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
avi@, can you please take a look? I am removing theming for popup windows because: ...
7 years, 8 months ago (2013-03-31 02:38:59 UTC) #1
Avi (use Gerrit)
sniff This was my last big rebellion, refusing to de-theme popups. lgtm
7 years, 8 months ago (2013-03-31 04:28:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13389002/9001
7 years, 5 months ago (2013-07-17 18:37:12 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 02:42:22 UTC) #4
Message was sent while issue was closed.
Change committed as 212217

Powered by Google App Engine
This is Rietveld 408576698