Add perf tests target to components.

Add perf tests target to components.

NOTE: This does not run on perf test bots yet.

BUG=138280
TEST=components_perftests
[email protected],[email protected],[email protected],[email protected]


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192607

[tfarina, 2013-03-31 17:06:51]

Please, review.

Thank you,

[boliu, 2013-03-31 17:30:03]

visitedlink_perftest.cc lgtm (I'm not owner)

Also I'm not qualified to review gyp change

https://codereview.chromium.org/13392002/diff/1/components/visitedlink/test/v...
File components/visitedlink/test/visitedlink_perftest.cc (right):

https://codereview.chromium.org/13392002/diff/1/components/visitedlink/test/v...
components/visitedlink/test/visitedlink_perftest.cc:82: VisitedLinkMaster
master(new DummyVisitedLinkEventListener(),
nit: No need for () here and below

[kaiwang, 2013-03-31 23:49:08]

LGTM, but please find a vistedlink OWNER to review this

[tfarina, 2013-03-31 23:53:06]

On 2013/03/31 23:49:08, kaiwang wrote:
> LGTM, but please find a vistedlink OWNER to review this

Done.

+sky for review!

[sky, 2013-04-01 15:00:24]

I think you're going to need to work with the infrastructure team before you can
land this.

[tfarina, 2013-04-01 15:51:48]

On Monday, April 1, 2013, wrote:

> I think you're going to need to work with the infrastructure team before
> you can
> land this.
>
> Why? I'm in contact with them already. Boliu can confirm.

This just adds a new target. The rest should to be done separated.


>
https://codereview.chromium.**org/13392002/<https://codereview.chromium.org/1...
>


-- 
Thiago

[sky, 2013-04-01 19:25:17]

LGTM - as long as you aren't moving tests yet doing this is fine.

[Jói, 2013-04-03 15:48:15]

Please confirm:
a) Is this perftest still being built and run as part of the 'perf_test' target
in chrome/chrome_tests.gypi;
b) Are you talking to the infrastructure folks about adding components_perftests
to the bots, after which the test could be removed from the 'perf_test' target?

If both are true, groovy.

Cheers,
Jói

[tfarina, 2013-04-03 16:21:33]

On Wednesday, April 3, 2013, wrote:

> Please confirm:
> a) Is this perftest still being built and run as part of the 'perf_test'
> target
> in chrome/chrome_tests.gypi;

Yes.


> b) Are you talking to the infrastructure folks about adding
> components_perftests
> to the bots, after which the test could be removed from the 'perf_test'
> target?
>
> Yes.


> If both are true, groovy.
>
> Both true :)

I emailed Kai as he had done similar in order to get components_unittests
running on trybots infrastruture. I copied Robbie Iannucci as well. And cmp
is on loop as well.

I think they will be able to help me to get this target running on the perf
bots as well.

Regards,



> Cheers,
> Jói
>
>
>
https://codereview.chromium.**org/13392002/<https://codereview.chromium.org/1...
>


-- 
Thiago

[commit-bot: I haz the power, 2013-04-05 14:28:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13392002/1

[commit-bot: I haz the power, 2013-04-05 14:28:30]

Presubmit check for 13392002-1 failed and returned exit status 1.

INFO:root:Found 2 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    components/components_tests.gypi

[Jói, 2013-04-05 15:06:17]

OWNERS stamp LGTM for components/

[commit-bot: I haz the power, 2013-04-05 15:48:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13392002/1

[commit-bot: I haz the power, 2013-04-05 18:29:44]

Change committed as 192607