Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13660002: Merge QUIC InterArrival congestion control code to chromium. (Closed)

Created:
7 years, 8 months ago by Ryan Hamilton
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Merge QUIC InterArrival congestion control code to chromium. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193483

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Copyright #

Patch Set 4 : Fix signed constants #

Patch Set 5 : Fix more gotchas #

Patch Set 6 : Fix bug #

Patch Set 7 : Disable InterArrivalOveruseDetectorTest and remove rand_r #

Patch Set 8 : fix quic_max_sized_map_test.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5392 lines, -13 lines) Patch
M net/net.gyp View 3 chunks +31 lines, -0 lines 0 comments Download
A net/quic/congestion_control/available_channel_estimator.h View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A net/quic/congestion_control/available_channel_estimator.cc View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A net/quic/congestion_control/available_channel_estimator_test.cc View 1 2 1 chunk +109 lines, -0 lines 0 comments Download
A net/quic/congestion_control/channel_estimator.h View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A net/quic/congestion_control/channel_estimator.cc View 1 2 3 1 chunk +110 lines, -0 lines 0 comments Download
A net/quic/congestion_control/channel_estimator_test.cc View 1 2 1 chunk +224 lines, -0 lines 0 comments Download
A net/quic/congestion_control/cube_root.h View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A net/quic/congestion_control/cube_root.cc View 1 2 1 chunk +87 lines, -0 lines 0 comments Download
A net/quic/congestion_control/cube_root_test.cc View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_bitrate_ramp_up.h View 1 2 1 chunk +65 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_bitrate_ramp_up.cc View 1 2 1 chunk +174 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc View 1 2 1 chunk +404 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_overuse_detector.h View 1 2 1 chunk +173 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_overuse_detector.cc View 1 2 3 4 1 chunk +258 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_overuse_detector_test.cc View 1 2 3 4 5 6 1 chunk +1114 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_probe.h View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_probe.cc View 1 2 1 chunk +117 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_probe_test.cc View 1 2 1 chunk +81 lines, -0 lines 0 comments Download
A + net/quic/congestion_control/inter_arrival_receiver.h View 1 2 3 chunks +16 lines, -11 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_receiver.cc View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_receiver_test.cc View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_sender.h View 1 2 1 chunk +95 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_sender.cc View 1 2 1 chunk +449 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_sender_test.cc View 1 2 3 4 5 1 chunk +565 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_state_machine.h View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_state_machine.cc View 1 2 1 chunk +163 lines, -0 lines 0 comments Download
A net/quic/congestion_control/inter_arrival_state_machine_test.cc View 1 2 1 chunk +126 lines, -0 lines 0 comments Download
A net/quic/congestion_control/quic_congestion_control_test.cc View 1 2 1 chunk +138 lines, -0 lines 0 comments Download
M net/quic/congestion_control/quic_congestion_manager.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
A net/quic/congestion_control/quic_congestion_manager_test.cc View 1 2 1 chunk +217 lines, -0 lines 0 comments Download
A net/quic/congestion_control/quic_max_sized_map.h View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
A net/quic/congestion_control/quic_max_sized_map_test.cc View 1 2 3 4 5 6 7 1 chunk +66 lines, -0 lines 0 comments Download
M net/quic/quic_time.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/mock_clock.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Ryan Hamilton
7 years, 8 months ago (2013-04-04 18:49:52 UTC) #1
ramant (doing other things)
lgtm https://chromiumcodereview.appspot.com/13660002/diff/2001/net/quic/congestion_control/available_channel_estimator.h File net/quic/congestion_control/available_channel_estimator.h (right): https://chromiumcodereview.appspot.com/13660002/diff/2001/net/quic/congestion_control/available_channel_estimator.h#newcode1 net/quic/congestion_control/available_channel_estimator.h:1: // Based on the inter arrival time of ...
7 years, 8 months ago (2013-04-04 21:49:07 UTC) #2
Ryan Hamilton
Thanks! https://chromiumcodereview.appspot.com/13660002/diff/2001/net/quic/congestion_control/available_channel_estimator.h File net/quic/congestion_control/available_channel_estimator.h (right): https://chromiumcodereview.appspot.com/13660002/diff/2001/net/quic/congestion_control/available_channel_estimator.h#newcode1 net/quic/congestion_control/available_channel_estimator.h:1: // Based on the inter arrival time of ...
7 years, 8 months ago (2013-04-04 22:15:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13660002/11001
7 years, 8 months ago (2013-04-04 22:27:32 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on linux_chromeos HTTP Error 400: Bad Request
7 years, 8 months ago (2013-04-04 22:44:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13660002/7006
7 years, 8 months ago (2013-04-05 02:10:09 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-05 02:28:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13660002/49001
7 years, 8 months ago (2013-04-10 17:59:42 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-10 18:19:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13660002/68001
7 years, 8 months ago (2013-04-10 19:13:42 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-10 19:32:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13660002/77001
7 years, 8 months ago (2013-04-10 20:05:53 UTC) #12
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 22:47:11 UTC) #13
Message was sent while issue was closed. 
Change committed as 193483

Powered by Google App Engine
This is Rietveld 408576698