Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13994014: Force refresh of shelf area when gesture completes to prevent (Closed)

Created:
7 years, 8 months ago by Harry McCleave
Modified:
7 years, 8 months ago
Reviewers:
James Cook, sadrul
CC:
chromium-reviews, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Force refresh of shelf area when gesture completes to prevent corruption of work area insets. BUG=230937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194763

Patch Set 1 #

Patch Set 2 : unit test #

Patch Set 3 : ws & ll #

Total comments: 2

Patch Set 4 : added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M ash/shelf/shelf_layout_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M ash/shelf/shelf_widget.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 2 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Harry McCleave
Mind taking a look when you get a chance.
7 years, 8 months ago (2013-04-12 20:27:39 UTC) #1
sadrul
The change makes sense. Please add a test though.
7 years, 8 months ago (2013-04-12 20:30:06 UTC) #2
sadrul
On 2013/04/12 20:30:06, sadrul wrote: > The change makes sense. Please add a test though. ...
7 years, 8 months ago (2013-04-15 16:56:37 UTC) #3
Harry McCleave
Got it, thank you. Ready for owner review.
7 years, 8 months ago (2013-04-15 22:29:04 UTC) #4
sadrul
LGTM https://codereview.chromium.org/13994014/diff/7001/ash/shelf/shelf_layout_manager_unittest.cc File ash/shelf/shelf_layout_manager_unittest.cc (right): https://codereview.chromium.org/13994014/diff/7001/ash/shelf/shelf_layout_manager_unittest.cc#newcode90 ash/shelf/shelf_layout_manager_unittest.cc:90: Let's add an expectation here too: if the ...
7 years, 8 months ago (2013-04-15 22:33:03 UTC) #5
Harry McCleave
https://codereview.chromium.org/13994014/diff/7001/ash/shelf/shelf_layout_manager_unittest.cc File ash/shelf/shelf_layout_manager_unittest.cc (right): https://codereview.chromium.org/13994014/diff/7001/ash/shelf/shelf_layout_manager_unittest.cc#newcode90 ash/shelf/shelf_layout_manager_unittest.cc:90: On 2013/04/15 22:33:03, sadrul wrote: > Let's add an ...
7 years, 8 months ago (2013-04-15 22:41:21 UTC) #6
James Cook
OWNERS lgtm
7 years, 8 months ago (2013-04-15 23:22:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13994014/7002
7 years, 8 months ago (2013-04-18 00:12:39 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 04:42:25 UTC) #9
Message was sent while issue was closed. 
Change committed as 194763

Powered by Google App Engine
This is Rietveld 408576698