Native api to get OAuth2 access tokens in Print Preview Web UI.

Native api to get OAuth2 access tokens in Print Preview Web UI.

BUG=179229
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194782

[gene, 2013-04-17 21:46:22]

lgtm, a few nits below

https://codereview.chromium.org/14093016/diff/7003/chrome/browser/ui/webui/pr...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/14093016/diff/7003/chrome/browser/ui/webui/pr...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:264: if
((*i)->type == type) {
you may consider making a temp variable holding (*i) for better readability

https://codereview.chromium.org/14093016/diff/7003/chrome/browser/ui/webui/pr...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:275: void
OnGetTokenSuccess(const OAuth2TokenService::Request* request,
empty line before this function

https://codereview.chromium.org/14093016/diff/7003/chrome/browser/ui/webui/pr...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:292:
(*i)->request.reset();
alignment

[Toscano, 2013-04-17 21:54:44]

lgtm

[Vitaly Buka (NO REVIEWS), 2013-04-18 00:06:36]

https://codereview.chromium.org/14093016/diff/7003/chrome/browser/ui/webui/pr...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/14093016/diff/7003/chrome/browser/ui/webui/pr...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:264: if
((*i)->type == type) {
On 2013/04/17 21:46:22, gene wrote:
> you may consider making a temp variable holding (*i) for better readability

Done.

https://codereview.chromium.org/14093016/diff/7003/chrome/browser/ui/webui/pr...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:264: if
((*i)->type == type) {
On 2013/04/17 21:46:22, gene wrote:
> you may consider making a temp variable holding (*i) for better readability

Done.

https://codereview.chromium.org/14093016/diff/7003/chrome/browser/ui/webui/pr...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:275: void
OnGetTokenSuccess(const OAuth2TokenService::Request* request,
On 2013/04/17 21:46:22, gene wrote:
> empty line before this function

Done.

https://codereview.chromium.org/14093016/diff/7003/chrome/browser/ui/webui/pr...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:292:
(*i)->request.reset();
On 2013/04/17 21:46:22, gene wrote:
> alignment

Done.

[commit-bot: I haz the power, 2013-04-18 00:06:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14093016/1005

[commit-bot: I haz the power, 2013-04-18 00:46:04]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-18 02:41:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14093016/1005

[commit-bot: I haz the power, 2013-04-18 05:31:59]

Change committed as 194782