Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 14225016: Add key to focus infobars (Closed)

Created:
7 years, 8 months ago by dmazzoni
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tfarina, mazda+watch_chromium.org, derat+watch_chromium.org, sail+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Add key to focus infobars On Windows & Chrome OS, pressing Alt+Shift+A will bring focus to the first control in the first infobar, if any are shown. No reason for 'A' - 'I' is already taken on Chrome OS, but all other hotkeys to directly focus a given pane are Alt+Shift+Letter shortcuts. BUG=226334 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_dll.rc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dmazzoni
7 years, 8 months ago (2013-04-17 21:11:27 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-18 18:19:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/14225016/1
7 years, 8 months ago (2013-04-18 18:22:23 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30295
7 years, 8 months ago (2013-04-18 22:06:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/14225016/1
7 years, 8 months ago (2013-04-18 23:16:45 UTC) #5
commit-bot: I haz the power
Change committed as 195030
7 years, 8 months ago (2013-04-19 00:49:24 UTC) #6
Peter Kasting
I would have suggested "N", as that's the second letter of infobar, and at least ...
7 years, 8 months ago (2013-04-19 00:52:57 UTC) #7
dmazzoni
7 years, 8 months ago (2013-04-19 05:22:41 UTC) #8
Message was sent while issue was closed.
See bug for more context. This is in direct response to blind users who heard
the announcement of the text of the infobar when it appeared, but had trouble
figuring out how to respond.

For Chrome OS in particular, I'm working on a subsequent change that will
announce the presence and also announce a key to press. The new announcement
would be something like:

Page has 1 alert: "google.com would like to use your location" - to review,
press Alt+Shift+A.

Powered by Google App Engine
This is Rietveld 408576698