Allow test files to use non-platform suffixes for PRESUBMIT checks.

Allow test files to use non-platform suffixes for PRESUBMIT checks.

The current check for deciding if a file is a unittest allows
a strict whitelist of platforms as suffixes. However, when a
unittest file becomes too large, it is useful to split it on
other axes than by platform. This allows a _suffix for a topic
to be used without failing production-only presubmit checks.

In other words, it considers foo_bar_unittest_baz.cc to be a
unittest.

There are many examples of foo_unittest_utils.cc which are used
only by unit tests throughout chromium, but they have been lucky
to avoid using FunctionForTesting type functions. In cc/ we have
run into this problem, so allowing our unittests to be considered
non-production code prevents false positive warnings about our
test files.

NOTRY=true
[email protected]
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195780

[M-A Ruel, 2013-04-23 12:56:32]

lgtm

[commit-bot: I haz the power, 2013-04-23 12:56:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14317011/2001

[commit-bot: I haz the power, 2013-04-23 12:57:13]

Change committed as 195780