Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 14370006: chrome: Add default tile size to about:flags. (Closed)

Created:
7 years, 8 months ago by reveman
Modified:
7 years, 8 months ago
Reviewers:
vangelis, sky, enne (OOO)
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

chrome: Add default tile size to about:flags. This adds default-tile-width and default-tile-height to about:flags so it's easy to experiment with different values for these constants. BUG=178317 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196833

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and use kOsAll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vangelis
https://codereview.chromium.org/14370006/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/14370006/diff/1/chrome/browser/about_flags.cc#newcode1335 chrome/browser/about_flags.cc:1335: kOsAndroid | kOsLinux | kOsCrOS, Why not all the ...
7 years, 8 months ago (2013-04-24 14:12:59 UTC) #1
reveman
https://codereview.chromium.org/14370006/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/14370006/diff/1/chrome/browser/about_flags.cc#newcode1335 chrome/browser/about_flags.cc:1335: kOsAndroid | kOsLinux | kOsCrOS, On 2013/04/24 14:12:59, vangelis ...
7 years, 8 months ago (2013-04-24 15:44:38 UTC) #2
vangelis
LGTM Love the constant names, BTW! :)
7 years, 8 months ago (2013-04-24 16:20:39 UTC) #3
reveman
7 years, 8 months ago (2013-04-26 15:46:37 UTC) #4
sky
LGTM
7 years, 8 months ago (2013-04-26 16:15:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/14370006/4001
7 years, 8 months ago (2013-04-26 17:51:37 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 21:15:36 UTC) #7
Message was sent while issue was closed.
Change committed as 196833

Powered by Google App Engine
This is Rietveld 408576698