Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14520026: webkit: Use base::MessageLoop. (Closed)

Created:
7 years, 8 months ago by xhwang
Modified:
7 years, 7 months ago
Reviewers:
kinuko, brettw
CC:
chromium-reviews, michaeln, vsevik, tzik+watch_chromium.org, yurys, darin-cc_chromium.org, sail+watch_chromium.org, cc-bugs_chromium.org, kinuko+watch, pfeldman
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 9

Patch Set 2 : comments #

Patch Set 3 : comments #

Total comments: 15

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+831 lines, -812 lines) Patch
M webkit/appcache/appcache_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_group_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_quota_client_unittest.cc View 1 11 chunks +11 lines, -11 lines 0 comments Download
M webkit/appcache/appcache_request_handler_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_response.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_response_unittest.cc View 1 7 chunks +8 lines, -8 lines 0 comments Download
M webkit/appcache/appcache_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_service_unittest.cc View 1 13 chunks +15 lines, -16 lines 0 comments Download
M webkit/appcache/appcache_storage_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_storage_impl_unittest.cc View 6 chunks +20 lines, -15 lines 0 comments Download
M webkit/appcache/appcache_test_helper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/appcache/appcache_update_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 55 chunks +60 lines, -59 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_url_request_job_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M webkit/appcache/mock_appcache_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/appcache/mock_appcache_storage.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/mock_appcache_storage_unittest.cc View 16 chunks +16 lines, -17 lines 0 comments Download
M webkit/blob/blob_url_request_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/blob/blob_url_request_job_unittest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M webkit/blob/local_file_stream_reader_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/blob/shareable_file_reference_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/blob/view_blob_internals_job.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/compositor_bindings/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/database/database_connections.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/database/database_connections_unittest.cc View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M webkit/database/database_quota_client_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M webkit/database/database_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/dom_storage/dom_storage_area_unittest.cc View 10 chunks +15 lines, -14 lines 0 comments Download
M webkit/dom_storage/dom_storage_context_unittest.cc View 8 chunks +12 lines, -16 lines 0 comments Download
M webkit/fileapi/async_file_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/copy_or_move_file_validator_unittest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M webkit/fileapi/file_system_file_stream_reader_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_mount_point_provider_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_quota_client_unittest.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_url_request_job_unittest.cc View 1 7 chunks +8 lines, -8 lines 0 comments Download
M webkit/fileapi/file_system_usage_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
webkit/fileapi/file_writer_delegate.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M webkit/fileapi/file_writer_delegate_unittest.cc View 14 chunks +16 lines, -16 lines 0 comments Download
M webkit/fileapi/isolated_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/local_file_stream_writer_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M webkit/fileapi/local_file_system_cross_operation_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/local_file_system_operation_unittest.cc View 58 chunks +64 lines, -65 lines 0 comments Download
M webkit/fileapi/local_file_system_operation_write_unittest.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M webkit/fileapi/local_file_system_quota_unittest.cc View 1 8 chunks +9 lines, -10 lines 0 comments Download
M webkit/fileapi/local_file_system_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/local_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/obfuscated_file_util_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/syncable/canned_syncable_file_system.cc View 1 2 3 7 chunks +11 lines, -9 lines 0 comments Download
M webkit/fileapi/syncable/local_file_change_tracker_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context_unittest.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download
M webkit/fileapi/syncable/syncable_file_operation_runner_unittest.cc View 1 16 chunks +21 lines, -21 lines 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/upload_file_system_file_element_reader_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/resource_request_body_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M webkit/glue/webthread_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webthread_impl.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_instance.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/plugin_lib.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 1 6 chunks +13 lines, -10 lines 0 comments Download
webkit/plugins/npapi/webplugin_impl.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/message_channel.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_flash_message_loop_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_scrollbar_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/quota_file_io_unittest.cc View 1 16 chunks +16 lines, -16 lines 0 comments Download
webkit/plugins/webview_plugin.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/quota/mock_quota_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
webkit/quota/mock_quota_manager_unittest.cc View 1 7 chunks +8 lines, -8 lines 0 comments Download
M webkit/quota/quota_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/quota/quota_manager_unittest.cc View 1 66 chunks +209 lines, -209 lines 0 comments Download
M webkit/quota/quota_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/quota/quota_temporary_storage_evictor_unittest.cc View 1 10 chunks +11 lines, -12 lines 0 comments Download
M webkit/quota/usage_tracker_unittest.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M webkit/support/test_webmessageportchannel.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/support/webkit_support.cc View 5 chunks +15 lines, -17 lines 0 comments Download
M webkit/tools/test_shell/notification_presenter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_appcache_system.h View 2 chunks +10 lines, -6 lines 0 comments Download
webkit/tools/test_shell/simple_appcache_system.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/simple_socket_stream_bridge.cc View 1 2 3 9 chunks +10 lines, -10 lines 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_agent.cc View 1 2 3 2 chunks +5 lines, -7 lines 0 comments Download
webkit/tools/test_shell/test_shell_devtools_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
webkit/tools/test_shell/test_shell_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_webblobregistry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webwidget_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
xhwang
7 years, 8 months ago (2013-04-27 06:33:06 UTC) #1
brettw
Same comment as for other patch. Sorry about the changes and thanks for working on ...
7 years, 7 months ago (2013-04-30 21:56:47 UTC) #2
xhwang
https://codereview.chromium.org/14520026/diff/1/webkit/appcache/appcache_response.cc File webkit/appcache/appcache_response.cc (right): https://codereview.chromium.org/14520026/diff/1/webkit/appcache/appcache_response.cc#newcode97 webkit/appcache/appcache_response.cc:97: weak_factory_.GetWeakPtr(), On 2013/04/30 21:56:47, brettw wrote: > Old wrapping ...
7 years, 7 months ago (2013-05-06 16:33:11 UTC) #3
xhwang
PTAL. Sorry for the rebase noise.
7 years, 7 months ago (2013-05-06 16:38:30 UTC) #4
brettw
LGTM https://codereview.chromium.org/14520026/diff/22001/webkit/database/database_connections_unittest.cc File webkit/database/database_connections_unittest.cc (right): https://codereview.chromium.org/14520026/diff/22001/webkit/database/database_connections_unittest.cc#newcode136 webkit/database/database_connections_unittest.cc:136: base::Bind(&ScheduleRemoveConnectionTask, I think the old style was fine. ...
7 years, 7 months ago (2013-05-06 17:43:33 UTC) #5
xhwang
https://codereview.chromium.org/14520026/diff/22001/webkit/database/database_connections_unittest.cc File webkit/database/database_connections_unittest.cc (right): https://codereview.chromium.org/14520026/diff/22001/webkit/database/database_connections_unittest.cc#newcode136 webkit/database/database_connections_unittest.cc:136: base::Bind(&ScheduleRemoveConnectionTask, On 2013/05/06 17:43:33, brettw wrote: > I think ...
7 years, 7 months ago (2013-05-07 00:11:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/14520026/30001
7 years, 7 months ago (2013-05-07 00:11:51 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=1696
7 years, 7 months ago (2013-05-07 00:21:24 UTC) #8
xhwang
kinuko@: could you please OWNERS review this?
7 years, 7 months ago (2013-05-07 00:27:36 UTC) #9
kinuko
lgtm
7 years, 7 months ago (2013-05-07 02:04:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/14520026/30001
7 years, 7 months ago (2013-05-07 03:10:19 UTC) #11
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 12:43:34 UTC) #12
Message was sent while issue was closed. 
Change committed as 198691

Powered by Google App Engine
This is Rietveld 408576698