Clean up software compositing switches.

Clean up software compositing switches. 

After this patch just --disable-gpu should be enough to put Chrome in software compositing mode for Aura builds.

Relanding https://codereview.chromium.org/13985036 which got a speculative revert.

[email protected],[email protected],[email protected]
NOTRY=true
BUG=229712, 230120
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197751

[slavi, 2013-05-01 20:34:04]

This is the same patch as https://codereview.chromium.org/13985036 which got an
unjust speculative" revert because of an unrelated failure of PointerLock test
in win7_aura.

PTAL

[jamesr, 2013-05-01 20:35:39]

still lgtm. if this patch is textually identical to the original one, i think
it'd be fine to reland with tbr's

[piman, 2013-05-01 20:36:26]

On Wed, May 1, 2013 at 1:35 PM, <[email protected]> wrote:

> still lgtm. if this patch is textually identical to the original one, i
> think
> it'd be fine to reland with tbr's
>

+1


>
>
https://codereview.chromium.**org/14598004/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-05-01 20:42:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14598004/1

[commit-bot: I haz the power, 2013-05-01 20:42:10]

Failed to apply patch for
content/browser/renderer_host/render_process_host_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/renderer_host/render_process_host_impl.cc
  Hunk #1 FAILED at 867.
  1 out of 1 hunk FAILED -- saving rejects to file
content/browser/renderer_host/render_process_host_impl.cc.rej

Patch:       content/browser/renderer_host/render_process_host_impl.cc
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc
b/content/browser/renderer_host/render_process_host_impl.cc
index
a0eda74ebcb48e8c89b39653c110ea0af438ed38..c2381c13cf6beb31decfa7aa0465d7ad4e553d54
100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -867,7 +867,7 @@ void
RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
     switches::kEnableSandboxLogging,
 #endif
     switches::kEnableSeccompSandbox,
-    switches::kEnableSoftwareCompositingGLAdapter,
+    switches::kEnableSoftwareCompositing,
     switches::kEnableStatsTable,
     switches::kEnableThreadedCompositing,
     switches::kEnableCompositingForFixedPosition,

[commit-bot: I haz the power, 2013-05-01 20:51:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14598004/6003

[commit-bot: I haz the power, 2013-05-01 21:03:47]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-05-01 21:40:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14598004/6003

[commit-bot: I haz the power, 2013-05-01 23:38:59]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-05-02 00:26:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14598004/6003

[commit-bot: I haz the power, 2013-05-02 00:26:48]

Change committed as 197751

[kinuko, 2013-05-02 05:02:28]

After around this change aura tests started to fail for ApiTests (which is also
failing in your win7_aura try results) and PointerLock. Previously the
"speculative revert" seems to have fixed those errors, and I suspect this one
may be real, may have something to do with those errors. (Though this CL says
it's for cleaning up)

[kinuko, 2013-05-02 05:03:21]

Let me revert this one again, if it doesn't fix I'll revert my revert. Thanks,

[slavi, 2013-05-02 19:32:10]

On 2013/05/02 05:02:28, kinuko wrote:
> After around this change aura tests started to fail for ApiTests (which is
also
> failing in your win7_aura try results) and PointerLock. Previously the
> "speculative revert" seems to have fixed those errors, and I suspect this one
> may be real, may have something to do with those errors. (Though this CL says
> it's for cleaning up)

PointerLock was failing before this patch (hence the NOTRY in it). Let me know
if you will re-revert.