QUIC - Added NetLog's Logging test to quic_network_transaction_unittest.cc.

QUIC - Added NetLog's Logging test to quic_network_transaction_unittest.cc. 
Deleted the DISABLED Logging test from quic_client_session_test.cc. 

Added code for MockUDPClientSocket::GetLocalAddress.

[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199394

[Ryan Hamilton, 2013-05-09 15:44:32]

Thanks for doing this.  I think this test definitely fits better here.

https://codereview.chromium.org/14614006/diff/1/net/quic/quic_network_transac...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/14614006/diff/1/net/quic/quic_network_transac...
net/quic/quic_network_transaction_unittest.cc:759: NULL, 0);
I think you need a MockWrite of the request which is causing this connection,
what do you think?

https://codereview.chromium.org/14614006/diff/1/net/quic/quic_network_transac...
net/quic/quic_network_transaction_unittest.cc:762: // Main job which will
succeed even though the alternate job fails.
Do we need the HTTP job to succeed?  I think we can make the MockConnect hang
forever.  That might make this test shorter.

https://codereview.chromium.org/14614006/diff/1/net/quic/quic_network_transac...
net/quic/quic_network_transaction_unittest.cc:780: // Port must be < 1024, or
the header will be ignored (since initial port was
Let's copy the code from line 578, just to be consistent.  (You could factor
that into a helper method, if you wish)

https://codereview.chromium.org/14614006/diff/1/net/quic/quic_network_transac...
net/quic/quic_network_transaction_unittest.cc:799:
EXPECT_FALSE(response->was_fetched_via_spdy);
shouldn't this be EXPECT_TRUE if it is happening via QUIC?

[ramant (doing other things), 2013-05-09 22:34:48]

Hi Ryan,
  Added the NetLog test to ForceQuic existing unit test (as we had discussed).
PTAL. thanks very much.

https://codereview.chromium.org/14614006/diff/1/net/quic/quic_network_transac...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/14614006/diff/1/net/quic/quic_network_transac...
net/quic/quic_network_transaction_unittest.cc:762: // Main job which will
succeed even though the alternate job fails.
On 2013/05/09 15:44:32, Ryan Hamilton wrote:
> Do we need the HTTP job to succeed?  I think we can make the MockConnect hang
> forever.  That might make this test shorter.

Done.

[Ryan Hamilton, 2013-05-09 22:45:16]

lgtm modulo one nit

https://codereview.chromium.org/14614006/diff/18001/net/quic/quic_network_tra...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/14614006/diff/18001/net/quic/quic_network_tra...
net/quic/quic_network_transaction_unittest.cc:108:
scoped_ptr<QuicEncryptedPacket> ConstructErrorPacket(
Please remove this method, as I believe it is now unused.

[ramant (doing other things), 2013-05-09 22:56:34]

Thanks much Ryan. Deleted unused method.

[commit-bot: I haz the power, 2013-05-09 22:56:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14614006/22001

[commit-bot: I haz the power, 2013-05-10 05:55:29]

Change committed as 199394