FileAPI: Copy base::FileUtilProxy::Entry to fileapi::DirectoryEntry

FileAPI: Copy base::FileUtilProxy::Entry to fileapi::DirectoryEntry

Copy (not move for now) Entry struct for directory operations from
base/files/file_util_proxy.h to webkit/fileapi/directory_entry.h
since only FileAPI/FilesystemAPI use the struct. This change contains
only mechanical changes.

base::FileUtilProxy::Entry will be removed in a separate change.


BUG=240245
TEST=none (should pass all existing tests)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201018

[nhiroki, 2013-05-16 04:18:04]

Hi, can you review this? Thanks!

[kinuko, 2013-05-16 05:17:31]

cool, thanks for doing this! lgtm

https://codereview.chromium.org/14671020/diff/7001/content/common/fileapi/fil...
File content/common/fileapi/file_system_messages.h (right):

https://codereview.chromium.org/14671020/diff/7001/content/common/fileapi/fil...
content/common/fileapi/file_system_messages.h:8: #include
"base/files/file_util_proxy.h"
Can we remove this now?

https://codereview.chromium.org/14671020/diff/7001/webkit/plugins/ppapi/ppb_f...
File webkit/plugins/ppapi/ppb_file_ref_impl.h (right):

https://codereview.chromium.org/14671020/diff/7001/webkit/plugins/ppapi/ppb_f...
webkit/plugins/ppapi/ppb_file_ref_impl.h:12: #include
"base/files/file_util_proxy.h"
I guessed including this in .cc (but not in .h) may work?

[nhiroki, 2013-05-16 05:44:52]

Thanks!

https://codereview.chromium.org/14671020/diff/7001/content/common/fileapi/fil...
File content/common/fileapi/file_system_messages.h (right):

https://codereview.chromium.org/14671020/diff/7001/content/common/fileapi/fil...
content/common/fileapi/file_system_messages.h:8: #include
"base/files/file_util_proxy.h"
On 2013/05/16 05:17:31, kinuko wrote:
> Can we remove this now?

Done.

https://codereview.chromium.org/14671020/diff/7001/webkit/plugins/ppapi/ppb_f...
File webkit/plugins/ppapi/ppb_file_ref_impl.h (right):

https://codereview.chromium.org/14671020/diff/7001/webkit/plugins/ppapi/ppb_f...
webkit/plugins/ppapi/ppb_file_ref_impl.h:12: #include
"base/files/file_util_proxy.h"
On 2013/05/16 05:17:31, kinuko wrote:
> I guessed including this in .cc (but not in .h) may work?

Done.

[nhiroki, 2013-05-16 06:03:18]

+mnissler@, kinaba@, vandebo@, raymes@

Hi, could you review this as owners?
This change moves just one struct to clean up FileAPI related files.

mnissler@ for base/files/file_util_proxy.h
kinaba@ for chrome/browser/chromeos/drive/file_system_proxy.cc
vandebo@ for chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.mm
raymes@ for content/renderer/pepper/*

Thanks,
nhiroki

[kinaba, 2013-05-16 06:52:45]

c/b/cros/drive lgtm

[Mattias Nissler (ping if slow), 2013-05-16 08:12:45]

Please pick somebody from base/OWNERS, I'm not really familiar with
file_util_proxy.h

[nhiroki, 2013-05-16 08:43:21]

On 2013/05/16 08:12:45, Mattias Nissler wrote:
> Please pick somebody from base/OWNERS, I'm not really familiar with
> file_util_proxy.h

Okay, I'll find other reviewer.

[nhiroki, 2013-05-16 08:47:28]

+brettw@

Hi Brett, could you review base/files/file_util_proxy.h as an owner?
This change moves just one struct to clean up FileAPI related files.

Thanks,
nhiroki

[vandebo (ex-Chrome), 2013-05-16 17:30:39]

mtp_device_delegate_impl_mac.mm LGTM

[raymes, 2013-05-16 17:35:22]

pepper lgtm

[kinuko, 2013-05-17 02:04:03]

https://codereview.chromium.org/14671020/diff/25003/webkit/fileapi/file_syste...
File webkit/fileapi/file_system_operation.h (right):

https://codereview.chromium.org/14671020/diff/25003/webkit/fileapi/file_syste...
webkit/fileapi/file_system_operation.h:57: // Holds metadata for file or
directory entry.
Oops, hiroki, I found this struct is used throughout from browser to renderer
process, and making dependency from renderer to
webkit/fileapi/file_system_operation.h is not great… can you move this to a
separate tiny file (like directory_entry.h) and rename the structure to like:
fileapi::DirectoryEntry ?  (Hopefully other owner's lgtm could be retained for
this minor naming change)

[nhiroki, 2013-05-17 06:12:53]

Moved the struct from file_system_operation.h to directory_entry.h along to
kinuko's comment.
Most of these changes should only rename.

kinuko: Can you take another look?

Thanks!

https://codereview.chromium.org/14671020/diff/25003/webkit/fileapi/file_syste...
File webkit/fileapi/file_system_operation.h (right):

https://codereview.chromium.org/14671020/diff/25003/webkit/fileapi/file_syste...
webkit/fileapi/file_system_operation.h:57: // Holds metadata for file or
directory entry.
On 2013/05/17 02:04:03, kinuko wrote:
> Oops, hiroki, I found this struct is used throughout from browser to renderer
> process, and making dependency from renderer to
> webkit/fileapi/file_system_operation.h is not great… can you move this to a
> separate tiny file (like directory_entry.h) and rename the structure to like:
> fileapi::DirectoryEntry ?  (Hopefully other owner's lgtm could be retained for
> this minor naming change)

Done.

[kinuko, 2013-05-17 06:32:33]

lgtm.

(Maybe you can leave the base/ change out and create a separate tiny CL just to
delete the dead code later, as base/ reviewers tend to be busy)

[nhiroki, 2013-05-17 07:05:11]

Brett, I removed you from reviewers since we decided not to change base/ in this
CL.
Sorry for interrupting you. Thanks.

[commit-bot: I haz the power, 2013-05-17 07:15:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14671020/66002

[nhiroki, 2013-05-17 07:39:23]

+jschuh@

Hi Justine, could you review content/common/fileapi/file_system_messages.h ?

I think this change doesn't make any security risk since fileapi::DirectoryEntry
is completely the same as previous base::FileUtilProxy::Entry.

[jschuh, 2013-05-17 17:21:52]

looks mechanical, so rubberstamp ipc security lgtm. (also, "justine" is a girl's
name :)

[nhiroki, 2013-05-19 04:00:50]

On 2013/05/17 17:21:52, Justin Schuh wrote:
> looks mechanical, so rubberstamp ipc security lgtm. (also, "justine" is a
girl's
> name :)

Justin: Thanks and sorry for misspelling...

[commit-bot: I haz the power, 2013-05-19 04:01:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14671020/66002

[commit-bot: I haz the power, 2013-05-19 05:49:54]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-05-19 12:40:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14671020/66002

[commit-bot: I haz the power, 2013-05-20 04:35:44]

Change committed as 201018