Move cc/debug/latency_info to ui/base.

Move cc/debug/latency_info to ui/base.

This structure would be useful in ui/surface, which can't depend on cc/.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202772

[jbauman, 2013-05-16 09:31:04]

It sounds like moving this to base/ isn't a popular idea, but maybe putting it
in ui/base makes more sense.

[sky, 2013-05-16 15:38:32]

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h
File ui/base/latency_info.h (right):

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h#new...
ui/base/latency_info.h:18: INPUT_EVENT_LATENCY_COMPONENT,
Why do you have an enum with a single value?

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h#new...
ui/base/latency_info.h:39: LatencyMap latency_components;
members should always be private and end with an '_'.

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h#new...
ui/base/latency_info.h:50: void AddLatencyNumber(LatencyComponentType component,
Add descriptions.

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h#new...
ui/base/latency_info.h:60: };
private:DISALLOW_COPY_AND_ASSIGN

[jbauman, 2013-05-20 16:48:21]

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h
File ui/base/latency_info.h (right):

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h#new...
ui/base/latency_info.h:18: INPUT_EVENT_LATENCY_COMPONENT,
On 2013/05/16 15:38:32, sky wrote:
> Why do you have an enum with a single value?

In my next set of patches I want to extend this for the different components
that care about latency (e.g. RENDER_MAIN_THREAD_LATENCY_COMPONENT, etc.). It's
a bit of a layering violation to put those here, but this structure is really
only for debugging so I'm hoping that's ok.

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h#new...
ui/base/latency_info.h:39: LatencyMap latency_components;
On 2013/05/16 15:38:32, sky wrote:
> members should always be private and end with an '_'.

Yeah, I've been vacillating about whether to change this to a class or keep it
as a struct (as it was previously). I can see arguments either way.

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h#new...
ui/base/latency_info.h:60: };
On 2013/05/16 15:38:32, sky wrote:
> private:DISALLOW_COPY_AND_ASSIGN

This is stored in STL datastructures, so I can't do that.

[sky, 2013-05-20 19:55:15]

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h
File ui/base/latency_info.h (right):

https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h#new...
ui/base/latency_info.h:39: LatencyMap latency_components;
On 2013/05/20 16:48:22, jbauman wrote:
> On 2013/05/16 15:38:32, sky wrote:
> > members should always be private and end with an '_'.
> 
> Yeah, I've been vacillating about whether to change this to a class or keep it
> as a struct (as it was previously). I can see arguments either way.

If you go with class, then all members private and end with '_'. Otherwise keep
it a struct. Either way though, members after functions.

[jbauman, 2013-05-20 20:07:50]

On 2013/05/20 19:55:15, sky wrote:
> https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h
> File ui/base/latency_info.h (right):
> 
>
https://codereview.chromium.org/14999012/diff/6001/ui/base/latency_info.h#new...
> ui/base/latency_info.h:39: LatencyMap latency_components;
> On 2013/05/20 16:48:22, jbauman wrote:
> > On 2013/05/16 15:38:32, sky wrote:
> > > members should always be private and end with an '_'.
> > 
> > Yeah, I've been vacillating about whether to change this to a class or keep
it
> > as a struct (as it was previously). I can see arguments either way.
> 
> If you go with class, then all members private and end with '_'. Otherwise
keep
> it a struct. Either way though, members after functions.

Ok, fixed - changed back to struct.

[sky, 2013-05-20 22:35:46]

LGTM

[jbauman, 2013-05-21 18:08:29]

Adding piman@ as OWNERS for content/ (this should be pretty much the same as
that older patch, except the location is different) and cdn@ as OWNERS reviewer
for the *_messages.h (mostly just moving stuff around).

[piman, 2013-05-21 18:19:36]

lgtm

[jbauman, 2013-05-23 15:16:33]

cdn@, ping.

[jbauman, 2013-05-28 21:37:24]

Or maybe jschuh@ can review the (hopefully trivial) content/*_messages.h
changes.

[Cris Neckar, 2013-05-28 21:50:12]

Sorry about that, IPC changes look like a rubber stamp LGTM

[commit-bot: I haz the power, 2013-05-28 22:34:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14999012/37001

[commit-bot: I haz the power, 2013-05-28 23:16:09]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-28 23:35:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/14999012/60001

[commit-bot: I haz the power, 2013-05-29 04:05:06]

Change committed as 202772