Issue 15021011: GPU: Prefer to restore from decoder state rather than GL state when possible.

Issue 15021011: GPU: Prefer to restore from decoder state rather than GL state when possible. (Closed)

Created:
7 years, 7 months ago by jonathan.backer

Modified:
7 years, 7 months ago

Reviewers:
greggman, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GPU: Prefer to restore from decoder state rather than GL state when possible. Some drivers are buggy. Wherever possible, use the decoder state restoration for the Scoped{Texture,Framebuffer}Binders. BUG=239509 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199542

Patch Set 1 : "" #

Patch Set 2 : Rebase #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -44 lines)			Patch
M	content/common/gpu/gpu_command_buffer_stub.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/common/gpu/media/exynos_video_decode_accelerator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/gpu/media/vaapi_h264_decoder.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/gpu/texture_image_transport_surface.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/async_pixel_transfer_delegate_egl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/async_pixel_transfer_delegate_idle.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/context_state.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/command_buffer/service/context_state.cc	View		2 chunks	+9 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/service/gl_context_virtual.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/gl_context_virtual.cc	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/service/gl_state_restorer_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gl_state_restorer_impl.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_mock.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gl/gl_context.h	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	ui/gl/gl_context.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	ui/gl/gl_state_restorer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/gl/scoped_binders.h	View		2 chunks	+19 lines, -2 lines	0 comments	Download
M	ui/gl/scoped_binders.cc	View		1 chunk	+43 lines, -18 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jonathan.backer

I think this is pretty close to what we've discussed. I haven't verified on device ...

7 years, 7 months ago (2013-05-09 21:38:56 UTC) #1

jonathan.backer

Tested on N10, GN, and Pixel with no measurable performance hit.

7 years, 7 months ago (2013-05-10 14:29:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/15021011/10001

7 years, 7 months ago (2013-05-10 16:41:07 UTC) #4

piman

https://chromiumcodereview.appspot.com/15021011/diff/10001/ui/gl/scoped_binders.cc File ui/gl/scoped_binders.cc (right): https://chromiumcodereview.appspot.com/15021011/diff/10001/ui/gl/scoped_binders.cc#newcode26 ui/gl/scoped_binders.cc:26: state_restorer_->RestoreAllTextureUnitBindings(); Should this restore the current FBO rather than ...

7 years, 7 months ago (2013-05-22 02:49:07 UTC) #6

jonathan.backer

7 years, 7 months ago (2013-05-22 13:35:53 UTC) #7

Message was sent while issue was closed.

On 2013/05/22 02:49:07, piman wrote:
>
https://chromiumcodereview.appspot.com/15021011/diff/10001/ui/gl/scoped_binde...
> File ui/gl/scoped_binders.cc (right):
> 
>
https://chromiumcodereview.appspot.com/15021011/diff/10001/ui/gl/scoped_binde...
> ui/gl/scoped_binders.cc:26: state_restorer_->RestoreAllTextureUnitBindings();
> Should this restore the current FBO rather than the texture bindings?

Yikes. Yep --- fixed here: https://codereview.chromium.org/15745002

Expand Messages | Collapse Messages