Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 15271002: Translate: enable context menu against pages having notranslate meta tag (Closed)

Created:
7 years, 7 months ago by Takashi Toyoshima
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Translate: enable context menu against pages having notranslate meta tag <meta name="google" value="notranslate"> tag disables Chrome Translate feature completely. But, it is better to enable it in context menu. - enable context menu against pages having notranslate meta tag - rename confusing parameter name |page_translatable| to |page_needs_translation| - rename confusing function name IsPageTranslatable to IsTranslationAllowed - implement GetMetaElementsWithAttribute directly since this function is removed from webkit/glue BUG=172593 [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201261

Patch Set 1 #

Patch Set 2 : (rebase) #

Patch Set 3 : fix to check content="notranslate" #

Patch Set 4 : update test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -61 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/language_state.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/language_state.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_tab_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/translate/translate_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/translate/translate_helper.cc View 1 2 3 chunks +31 lines, -41 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Takashi Toyoshima
Hi mad, Can you take a look? Basically, we want to enable context menu always ...
7 years, 7 months ago (2013-05-17 09:12:49 UTC) #1
Mattias Nissler (ping if slow)
chrome/browser/policy LGTM
7 years, 7 months ago (2013-05-17 11:32:37 UTC) #2
MAD
LGTM! Thanks... BYE MAD
7 years, 7 months ago (2013-05-17 17:40:25 UTC) #3
Takashi Toyoshima
+sky for chrome/common/render_messages.h (trivial comment change)
7 years, 7 months ago (2013-05-20 05:49:00 UTC) #4
sky
LGTM - feel free to TBR trivial changes
7 years, 7 months ago (2013-05-20 14:59:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/15271002/29001
7 years, 7 months ago (2013-05-20 15:03:00 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=3746
7 years, 7 months ago (2013-05-20 15:13:18 UTC) #7
Takashi Toyoshima
Oops, IPC message changes need a security review. But, this change doesn't contain real IPC ...
7 years, 7 months ago (2013-05-21 04:08:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/15271002/29001
7 years, 7 months ago (2013-05-21 04:09:03 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 08:36:24 UTC) #10
Message was sent while issue was closed.
Change committed as 201261

Powered by Google App Engine
This is Rietveld 408576698