Moved DOMActionType information from extras into a real field (ActivityLog)

Moved DOMActionType information from extras into a real field (ActivityLog)

Previously, the DOMActionType was being sent from the renderer to the browser ActivityLog as a string. It was then being turned into an enum. I've now moved it to its own proper field, and it's being marshaled across the renderer/browser boundary as an int that matches an enum instead of as a string.

[email protected]
BUG=229703
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203037

[felt, 2013-05-21 00:50:30]

Hi Matt, can you please review this?

(Domagoj, this incidentally fixes the confusing if-statement that you
mentioned.)

[Matt Perry, 2013-05-21 22:14:21]

https://codereview.chromium.org/15520002/diff/1/chrome/renderer/extensions/do...
File chrome/renderer/extensions/dom_activity_logger.cc (right):

https://codereview.chromium.org/15520002/diff/1/chrome/renderer/extensions/do...
chrome/renderer/extensions/dom_activity_logger.cc:21: enum CallType {
It'd be better to use the same enum on both ends of the IPC channel. Can you
move DOMAction::DOMActionType to chrome/common/extensions/dom_action_types.h ,
and use it in both renderer and browser?

https://codereview.chromium.org/15520002/diff/1/chrome/renderer/extensions/do...
chrome/renderer/extensions/dom_activity_logger.cc:53: const std::string type =
std::string(call_type.utf8());
the extra std::string cast is unnecessary

https://codereview.chromium.org/15520002/diff/1/chrome/renderer/extensions/do...
chrome/renderer/extensions/dom_activity_logger.cc:55: params.call_type =
static_cast<int>(GETTER);
I believe these casts are unnecessary.

[felt, 2013-05-22 01:34:39]

https://codereview.chromium.org/15520002/diff/1/chrome/renderer/extensions/do...
File chrome/renderer/extensions/dom_activity_logger.cc (right):

https://codereview.chromium.org/15520002/diff/1/chrome/renderer/extensions/do...
chrome/renderer/extensions/dom_activity_logger.cc:21: enum CallType {
On 2013/05/21 22:14:21, Matt Perry wrote:
> It'd be better to use the same enum on both ends of the IPC channel. Can you
> move DOMAction::DOMActionType to chrome/common/extensions/dom_action_types.h ,
> and use it in both renderer and browser?

Done.

https://codereview.chromium.org/15520002/diff/1/chrome/renderer/extensions/do...
chrome/renderer/extensions/dom_activity_logger.cc:53: const std::string type =
std::string(call_type.utf8());
On 2013/05/21 22:14:21, Matt Perry wrote:
> the extra std::string cast is unnecessary

Done.

https://codereview.chromium.org/15520002/diff/1/chrome/renderer/extensions/do...
chrome/renderer/extensions/dom_activity_logger.cc:53: const std::string type =
std::string(call_type.utf8());
On 2013/05/21 22:14:21, Matt Perry wrote:
> the extra std::string cast is unnecessary

Done.

https://codereview.chromium.org/15520002/diff/1/chrome/renderer/extensions/do...
chrome/renderer/extensions/dom_activity_logger.cc:55: params.call_type =
static_cast<int>(GETTER);
On 2013/05/21 22:14:21, Matt Perry wrote:
> I believe these casts are unnecessary.

Done.

[Matt Perry, 2013-05-22 01:43:55]

https://codereview.chromium.org/15520002/diff/11001/chrome/common/extensions/...
File chrome/common/extensions/dom_action_types.h (right):

https://codereview.chromium.org/15520002/diff/11001/chrome/common/extensions/...
chrome/common/extensions/dom_action_types.h:13: GETTER = 0,      // For Content
Script DOM manipulations
You should prefix these, either as DOM_ACTION_TYPE_GETTER, or in a static class,
e.g.
struct DomActionType {
  enum Type {
    GETTER,
    ..
  };
};

[Matt Perry, 2013-05-22 01:44:15]

LGTM with last comment addressed.

[felt, 2013-05-22 02:19:45]

Chris & James, can you please check out these changes to extension_messages.h
and chrome_render_message_filter.cc, respectively? Thanks!

PS Thanks Matt.

https://codereview.chromium.org/15520002/diff/11001/chrome/common/extensions/...
File chrome/common/extensions/dom_action_types.h (right):

https://codereview.chromium.org/15520002/diff/11001/chrome/common/extensions/...
chrome/common/extensions/dom_action_types.h:13: GETTER = 0,      // For Content
Script DOM manipulations
On 2013/05/22 01:43:55, Matt Perry wrote:
> You should prefix these, either as DOM_ACTION_TYPE_GETTER, or in a static
class,
> e.g.
> struct DomActionType {
>   enum Type {
>     GETTER,
>     ..
>   };
> };

Done.

[James Hawkins, 2013-05-22 18:26:21]

lgtm

[palmer, 2013-05-22 22:15:31]

Unfortunately I'm a bit swamped at the moment; cdn, can you please review this
for IPC security?

[felt, 2013-05-23 17:25:41]

cdn- please let me know if you need any background on what the Activity Log is
doing!

On 2013/05/22 22:15:31, Chromium Palmer wrote:
> Unfortunately I'm a bit swamped at the moment; cdn, can you please review this
> for IPC security?

[felt, 2013-05-25 19:38:44]

cdn - Gentle ping, can you please take a look at this CL when you come back from
the weekend? Thanks!

On 2013/05/23 17:25:41, felt wrote:
> cdn- please let me know if you need any background on what the Activity Log is
> doing!
> 
> On 2013/05/22 22:15:31, Chromium Palmer wrote:
> > Unfortunately I'm a bit swamped at the moment; cdn, can you please review
this
> > for IPC security?

[Cris Neckar, 2013-05-29 20:17:56]

IPC changes LGTM

[commit-bot: I haz the power, 2013-05-29 21:01:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/15520002/25001

[commit-bot: I haz the power, 2013-05-30 03:24:27]

Change committed as 203037